Load nothing from Tapioca by default #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-require-nothing-by-default
branch
from
0329dc3 to
9281492
Compare
Morriar
reviewed
Feb 17, 2022
Sorbet runtime checks for method arguments change depending on if the method arguments are all simple types and/or the return type is a simple type or not. Ever since we introduced the `TypeVariableModule` to make name binding easier, type members/templates started being wrapped in simple types when coerced, as well. However, this ends up breaking the assumptions that Sorbet runtime is making, thus causing test failures for DSL compilers with generic typed arguments in the constructor. The solution is to hook the `T::Utils.coerce` method to coerce those types to a custom `T::TypeVariable` subclass that records its name. By doing this, we preserve the checks that Sorbet runtime is doing and we preserve the name of the type variable.
paracycle
force-pushed
the
uk-require-nothing-by-default
branch
from
1f830ac to
9297b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The split between top level
tapioca.rbrequires andtapioca/internal.rbrequires was creating an ordering problem. Also, the default require of Tapioca might be pulling into the requiring much more than we intended, and since we do messy things with Sorbet runtime, that could end up being distruptive.Implementation
It is best to not load anything from the default require (we basically define the top-level
Tapiocanamespace and some constants under it, only) and to load everything for the CLI usingtapioca/internal.rb. This allows us to order the requires so that all the trackers and other runtime patches get loaded before things that depend on them.NOTE: This implies that people who write their own DSL compilers will have to explicitly do a
require "tapioca/dsl/compiler".Tests
No new tests.