Do not crash when trying to generate DSL RBIs on non-rails apps #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <[email protected]> Co-authored-by: Ufuk Kayserilioglu <[email protected]>
KaanOzkan
approved these changes
Mar 9, 2022
|
Looks like there's need to update a test expectation @Morriar |
Signed-off-by: Alexandre Terrasa <[email protected]> Co-authored-by: Ufuk Kayserilioglu <[email protected]>
Morriar
force-pushed
the
at-uk-do-not-crash-on-non-rails-app
branch
from
74389c7 to
9ec7826
Compare
|
Should we print a message when we don't have a Rails application? My understanding of what will happen is that we're simply not going to process any constants, but maybe we could print a message saying |
We have a WIP branch to support non-rails application, it should be supported "soon", at least before Tapioca 1.0 is out ⛵ |
vinistock
approved these changes
Mar 9, 2022
paracycle
reviewed
Mar 9, 2022
| @@ -8,8 +8,8 @@ module Dsl | |||
| module Compilers | |||
| class ActiveRecordFixturesSpec < ::DslSpec | |||
| describe "Tapioca::Dsl::Compilers::ActiveRecordFixtures" do | |||
| describe "initialize" do | |||
| it "gathers only the ActiveSupport::TestCase base class" do | |||
| describe "without a Rails app" do | |||
paracycle
pushed a commit
that referenced
this pull request
Mar 29, 2022
Do not crash when trying to generate DSL RBIs on non-rails apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid getting a scary stack trace when running
tapioca dslin the wrong kind of app:Implementation
Check if we are in a Rails app with
Rails.application.