Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rbi to v0.0.14 #866

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Bump rbi to v0.0.14 #866

merged 2 commits into from
Mar 15, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Mar 15, 2022

Motivation

Get a patch for parsing empty params() and returns() calls as well as better error handling.

@Morriar Morriar added the dependencies Pull requests that update a dependency file label Mar 15, 2022
@Morriar Morriar requested a review from a team March 15, 2022 13:37
@Morriar Morriar self-assigned this Mar 15, 2022
@vinistock
Copy link
Member

Do we want to restrict this in the gemspec?

Morriar added 2 commits March 15, 2022 10:01
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
@Morriar
Copy link
Collaborator Author

Morriar commented Mar 15, 2022

Do we want to restrict this in the gemspec?

It's not required per se but I guess it wouldn't hurt 👍

Thanks!

@Morriar Morriar enabled auto-merge March 15, 2022 14:03
@Morriar Morriar merged commit 66cd8d7 into main Mar 15, 2022
@Morriar Morriar deleted the at-bump-rbi branch March 15, 2022 14:12
@paracycle
Copy link
Member

Do we want to restrict this in the gemspec?

Yes, we want this, since we want the rbi gem to feel like it was a part of Tapioca almost. That's why, if there are significant bug fixes, etc in an rbi release, we want Tapioca to force depend on those changes.

paracycle pushed a commit that referenced this pull request Mar 29, 2022
paracycle pushed a commit that referenced this pull request Mar 29, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to production May 13, 2022 23:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants