Fix block with no param generation #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue occured when running the dsl command for an ActiveSupport::CurrentAttributes class with a method accepting a block with type: `T.proc.void`, resulting in the invalid `.params()` being generated.
|
Thanks, this looks great. I took the liberty of pushing the sanitization one level down into the |
paracycle
approved these changes
Mar 25, 2022
paracycle
force-pushed
the
pj/fix-blocks-in-current-attributes
branch
from
0fedb73 to
a13a08b
Compare
paracycle
added a commit
that referenced
this pull request
Mar 29, 2022
Fix block with no param generation
paracycle
added a commit
that referenced
this pull request
Mar 29, 2022
Fix block with no param generation
paracycle
added a commit
that referenced
this pull request
Mar 29, 2022
Fix block with no param generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The issue occured when running the dsl command for an
ActiveSupport::CurrentAttributes class with a method accepting a block
with type:
T.proc.void, resulting in the invalid.params()beinggenerated.
Implementation
The fix is a total shot in the dark, and I have no idea if it's a good approach, or if there's a better one
Tests
The test change is almost 1:1 the issue I faced in my own code