Start using compared by identity Set operations for UrlHelpers#includes_helper?
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a difference of arrays for finding interesting ancestors, we need to be careful in case a constant has overridden `Object#hash`. Since array subtractions use `Object#hash` to determine equality, this operation will fail. Instead, we need to use a Set with compare-by-identity semantics, so that `Object#hash` is never called.
Morriar
reviewed
Mar 29, 2022
| @@ -54,7 +54,7 @@ def self.gather_constants; end | |||
| sig { returns(T::Set[Module]) } | |||
| def self.processable_constants | |||
| @processable_constants ||= T.let( | |||
| Set.new(gather_constants).tap(&:compare_by_identity), | |||
| T::Set[Module].new(gather_constants).compare_by_identity, | |||
There was a problem hiding this comment.
Is this change relevant in this commit?
There was a problem hiding this comment.
I could do without it, but seen as I changed the signature of Set#compare_by_identity to not need the tap here anymore, I thought I'd include this too.
vinistock
approved these changes
Mar 29, 2022
Morriar
reviewed
Mar 29, 2022
| @@ -1,5 +1,6 @@ | |||
| # typed: strict | |||
|
|
|||
| class Set | |||
| sig { returns(T.self_type) } | |||
There was a problem hiding this comment.
Should we upstream this change? https://github.com/sorbet/sorbet/blob/master/rbi/stdlib/set.rbi#L174-L178
There was a problem hiding this comment.
Yes, that's what I'll do next.
Morriar
approved these changes
Mar 29, 2022
paracycle
added a commit
that referenced
this pull request
Mar 29, 2022
…-hash Start using compared by identity Set operations for `UrlHelpers#includes_helper?`
paracycle
added a commit
that referenced
this pull request
Mar 29, 2022
…-hash Start using compared by identity Set operations for `UrlHelpers#includes_helper?`
paracycle
added a commit
that referenced
this pull request
Mar 29, 2022
…-hash Start using compared by identity Set operations for `UrlHelpers#includes_helper?`
|
Thanks @paracycle 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When doing a difference of arrays for finding interesting ancestors, we need to be careful in case a constant has overridden
Object#hash. Since array subtractions useObject#hashto determine equality, this operation will fail.Implementation
Instead, we need to use a Set with compare-by-identity semantics, so that
Object#hashis never called.Tests