Explicitly load descendants patch in ActiveSupport #924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #517
We utilize
Class#descendants
in tapioca. As reported in the above issue in Rails versions prior tov6.1.0
, upon loading of aRails::Engine
theClass
redefinition that definesdescendants
isn't loaded.Implementation
Explicitly load the file using our internal
safe_require
method.Tests
I tested it manually. Automated testing is likely not worth the effort in comparison to the change.