Botany Changes and Fixes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shroopy
force-pushed
the
mantis-botany-rework
branch
2 times, most recently
from
2e12096 to
2d5905a
Compare
Shroopy
force-pushed
the
mantis-botany-rework
branch
from
2d5905a to
d064a1e
Compare
…s perennial growth
…, making perennial growth possible to obtain
Shroopy
pushed a commit
that referenced
this pull request
Jul 29, 2024
…avaland syndicate base. Attempt #2 (#28934) * Adds holo-fan and two thermomachine and emitters boards to lavaland syndicate base. Attempt #2 (#84934) ## About The Pull Request This is my second PR after I goofed up in the first by merging from master. Adds a holofan and two thermomachine boards to the engineering crate in the lavaland syndie base, and adds two emitter boards to its SM room. ## Why It's Good For The Game The lavaland syndie base has no holofan and is limited to two thermo machines (four thermomachines and only one emitter if the SM shard room spawns). This limits atmospheric gameplay and restricts the freedom in creating set-ups within the base even though it starts with a surplus of T4 parts and four gas miners. These additions should improve the quality of base as an atmospheric ghost role and make it less frustrating when making burns, coolers, dealing with gas leaks Etc. as well as improve SM shard gameplay when creating high power set ups or tesla. ## Changelog :cl: qol: Holofan and two thermomachine and emitter boards in lavaland syndicate base. /:cl: * Adds holo-fan and two thermomachine and emitters boards to lavaland syndicate base. Attempt #2 --------- Co-authored-by: TheNobodyofimportance <[email protected]>
Shroopy
force-pushed
the
mantis-botany-rework
branch
from
5802ad6 to
d5db4ec
Compare
Shroopy
pushed a commit
that referenced
this pull request
Dec 6, 2024
…embeds on reagent spears (#2536) ## About The Pull Request This fixes two bugs. Quoting the player reported bug: Exploit #1 - Twitch Next Move modificier This one needs a bit of VV to test mostly to speed up the conditions, but its doable by a miner with a bit of skill. You need the berserker armor of the chosen one, or alternatively, the Dexterous mutation and a way to remove it (I think you can do so with mutadone, but never tried, regardless!) and Twitch. The short of it is that the next move variable is always edited with multiplicatives, but Twitch was coded with an aditive, so alternating one and another and then removing one effect and letting the other run out would net you with a lower than 1 next move variable. Exploit #2 - God Slaying Spear This one is easy to test, basically you all got a spear with better embeed stats than ninja stars, which embeeds most of the time thanks to its high embeed chance, plus its armor penetration, with no chance for it to fall out naturally so it has to be manually removed. Since it has a Bulky weight class, its damage multiplier is 4 plus the pain multiplier being 6, doing 24 damage per tick and on extraction, being able to kill a person that gets it in 10 seconds, even if armored. We had a whole clique abusing this as icecats on nova, and even combining it with morphine. https://github.com/Bubberstation/Bubberstation/blob/master/modular_skyrat/modules/reagent_forging/code/forge_weapons.dm#L136 ## Why It's Good For The Game Fixes some seriously game breaking bugs no one's abused yet, discovered on Nova, ## Proof Of Testing <details> <summary>Screenshots/Videos</summary> </details> ## Changelog :cl: OrbisAnima (code for 1), ReturnToZender (code for 2) fix: Fixes an exploit with Twitch, and the reagent forged spear's embedding. /:cl: --------- Co-authored-by: Arturlang <[email protected]>
Shroopy
pushed a commit
that referenced
this pull request
Dec 7, 2024
# This is the 1st commit message: goofsec hud # This is the commit message #2: the sensible tgui errors # This is the commit message #3: Gets it to compile # This is the commit message #4: Fixes all extra runtimes # This is the commit message #5: TGUI Fixes 1 # This is the commit message #6: Removes open dream check # This is the commit message #7: Ticked file enforcement # This is the commit message #8: A very harsh way to fix potential missing icons # This is the commit message #9: Wipes all the errorneously included files # This is the commit message #10: fixes missing_icons fully # This is the commit message #11: some extra ci fixes before I forget # This is the commit message #12: WHAT THE FUCK # This is the commit message #13: really? # This is the commit message #14: bye waffles # This is the commit message #15: hooray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Changelog
🆑
balance: Plants now take longer to grow but need less frequent maintenance.
balance: Perennial growth cannot be taken from any plant with no trait. Many plants now have the perennial growth trait.
balance: The seed generator now makes fewer seeds.
/:cl: