Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you planning to add PixiJS V8 support for Transformer package? #105

Open
talhaozdemir opened this issue Mar 31, 2024 · 6 comments
Open

Comments

@talhaozdemir
Copy link

No description provided.

@talhaozdemir talhaozdemir changed the title Do you planning to add PixiJS V8 support? Do you planning to add PixiJS V8 support for Transformer package? Mar 31, 2024
@ShukantPal
Copy link
Owner

I'm happy to review a PR. At the moment, I'm unable to work on this myself due to time constraints and managing mental health.

@talhaozdemir
Copy link
Author

@ShukantPal I tried to migrate the plugin to V8 but I have some issues on some scripts, I need your help at this point.

1- decomposeTransform(displayObject.transform, tempMatrix)

displayObject doesn't have transform property, so I changed this to

decomposeTransform(
    {
      rotation: displayObject.rotation,
      skew: displayObject.skew,
      scale: displayObject.scale,
      pivot: displayObject.pivot,
      position: displayObject.position,
    } as Transform,
    tempMatrix,
  );

but in this case, it is working buggy, for example if I try to scale with handles, the object disappear when negative scaling occurs

2- I don't know why, if dev tools opened in the browser, I cannot transform object position, it is slow

I am sharing the working demo, If you can help, I would be very happy. I add comments starts with "// V8" for changed parts

transformer-test-v8.zip

@ShukantPal
Copy link
Owner

@talhaozdemir Can you open a draft PR? I'll take a look when I have time.

@talhaozdemir
Copy link
Author

talhaozdemir commented Apr 7, 2024

@ShukantPal thanks, I've opened a PR.

@jesusrojasp
Copy link

Any updates? It's been months since the draft PR for v8 was opened and no news so far :/

@ShukantPal
Copy link
Owner

There is no update as of yet, unfortunately. Someone sponsored #107 and that took a massive effort to upgrade the codebase (see the diff).

Again, happy to review a working contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants