Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @pixi-essentials/svg to v8 #107

Merged
merged 21 commits into from
Oct 8, 2024
Merged

Upgrade @pixi-essentials/svg to v8 #107

merged 21 commits into from
Oct 8, 2024

Conversation

ShukantPal
Copy link
Owner

@ShukantPal ShukantPal commented Apr 29, 2024

  • Upgrade pnpm, Rush
  • Upgrade @pixi-essentials/gradients to v8
  • Upgrade @pixi-essentials/texture-allocator to v8
  • Use built-in Culler instead of @pixi-essentials/cull
  • Upgrade @pixi-essentials/svg

- [x] Upgrade pnpm, Rush
- [x] Upgrade @pixi-essentials/gradients to v8
- [ ] Upgrade @pixi-essentials/texture-allocator to v8
- [ ] Use built-in `Culler` instead of @pixi-essentials/cull
- [ ] Upgrade @pixi-essentials/svg
Copy link

stackblitz bot commented Apr 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ShukantPal ShukantPal marked this pull request as ready for review April 29, 2024 05:59
@ShukantPal ShukantPal changed the title shukant/svg-upgrade Upgrade @pixi-essentials/svg to v8 Apr 29, 2024
@yunsii
Copy link

yunsii commented Jun 20, 2024

Any progress? Maybe I can help.

@ShukantPal
Copy link
Owner Author

Yeah I was waiting on my PRs to get merged into pixijs core. They got merged this week

@yunsii
Copy link

yunsii commented Jun 21, 2024

I see, here is a upstream PR pixijs/pixijs#10508

Migrated dependencies to ^8.2.0 and updated imports. Also updated to new types wherever possible before touching graphics code.
Worked on fixing up SVG <path /> element implementations for simple shapes.
@ShukantPal
Copy link
Owner Author

pixijs/pixijs#10965

@ShukantPal
Copy link
Owner Author

pixijs/pixijs#10966

packages/svg/src/SVGScene.ts Fixed Show fixed Hide fixed
packages/svg/src/SVGScene.ts Fixed Show fixed Hide fixed
@ShukantPal ShukantPal merged commit b1ff690 into master Oct 8, 2024
8 checks passed
@ShukantPal ShukantPal deleted the shukant/svg-upgrade branch October 8, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants