Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another cloudkey workaround #66

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

milesd
Copy link
Contributor

@milesd milesd commented Aug 21, 2023

Now this block of code is duplicated in three places :)

@notheotherben
Copy link
Member

@milesd I see you've left this in draft for a while - if you think this would be a valuable addition to the package, feel free to mark it as non-draft and we can get the ball rolling on landing it (and potentially looking at how we can refactor the logic around version selection).

@milesd
Copy link
Contributor Author

milesd commented Oct 21, 2023

I got sucked away at work and had to circle back, but now that I'm about to try out UniFi Network Application 8.0.2 I'll have another chance to run into problems and update.

@milesd milesd marked this pull request as ready for review October 21, 2023 18:01
@notheotherben
Copy link
Member

Thank you, let me get this merged and a new release out so that you can test directly there.

@notheotherben notheotherben merged commit cf9e67b into SierraSoftworks:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants