Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Public headers for Swift Package. #114 #153

Merged

Conversation

apolwork
Copy link
Contributor

@apolwork apolwork commented Nov 8, 2024

Purpose

Resolves umbrella warning when Sift is integrated by SPM. #114

Summary

Root cause

  1. Swift package does not support root source folder as a folder for public headers.

Solution

Created dedicated folder and header file for required public headers
New header file is specific for Swift Package only, that is why it is not included into the project file.

Testing

Step to reproduce

  1. Create New Static Library project. Use
  2. Add sift-ios through the Package Dependencies
  3. Add import Siftto swift file
  4. Build target

Checklist

  • The change was thoroughly tested manually
  • The change was covered with unit tests (Not applicable)
  • The change was tested with the integration example (Not applicable)
  • Necessary changes were made in the integration example (Not applicable)
  • New functionality is reflected in README (Not applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants