Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/sources requests do not work #584

Closed
tkurki opened this issue Aug 9, 2018 · 0 comments
Closed

/sources requests do not work #584

tkurki opened this issue Aug 9, 2018 · 0 comments

Comments

@tkurki
Copy link
Member

tkurki commented Aug 9, 2018

Requests with prefix signalk/v1/api/sources do not work, because DeltaCache Full build optimisation considers only deltas for the path in the request - which is obviously wrong, becase /sources content is built from all deltas.
@tkurki tkurki added the bug label Aug 9, 2018
tkurki added a commit that referenced this issue Aug 9, 2018
@tkurki
fix: /sources in deltaCache full build
ae867b3 
If the request is under /sources we need to build the full
based on all deltas so that the full /sources structure gets
built.

Fixes #584.
@tkurki tkurki mentioned this issue Aug 9, 2018
Merged
tkurki added a commit that referenced this issue Aug 9, 2018
@tkurki
fix: /sources in deltaCache full build
d8f736d 
If the request is under /sources we need to build the full
based on all deltas so that the full /sources structure gets
built.

Fixes #584.
tkurki added a commit that referenced this issue Aug 9, 2018
@tkurki
fix: /sources in deltaCache full build (#585)
efa17a2 
If the request is under /sources we need to build the full
based on all deltas so that the full /sources structure gets
built.

Fixes #584.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkurki