fix: Kubernetes deployment failure #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore usability of the Kubernetes manifest by replacing the deploymentAPI version which was deprecated in Kubernetes 1.16 with the version currently in common use. resolves #1875
Some of the manifest attributes appear to have come from originally building the file by describing a live deployment. This includes items specific to the particular cluster and point-in-time of the deployment which do not belong in a manifest intended for use in other clusters.
Removed a couple of unnecessary extra newlines at end of the Kubernetes manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes deployment manifest references an API that is no longer available. Change this to the equivalent that's available in current K8s implementations along with some updates to make deploying the Signal K Server on Kubernetes clusters easier.
Validation
Manual Testing
Screenshot
Copilot Description
Documentation updates:
README.md: Added a section pointing to new Kubernetes Quickstart instructions.kubernetes/README.md: Created a new README with detailed instructions for deploying Signal K Server on Kubernetes, including setup, accessing the server, and uninstalling.Kubernetes manifest files:
kubernetes/signalk-deployment.yaml: Updated the deployment manifest to useapiVersion: apps/v1and removed unnecessary metadata fields. [1] [2] [3] [4]kubernetes/signalk-ingress.yaml: Added a new ingress manifest for routing HTTP traffic to the Signal K Server.Related Issues