feature: support relativePosition.radius in subscriptions #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
reviewed
Nov 25, 2017
package.json
Outdated
| @@ -111,7 +111,8 @@ | |||
| "stream-throttle": "^0.1.3", | |||
| "through": ">=2.2.7 <3", | |||
| "ws": "^3.0.0", | |||
| "xml2js": "^0.4.17" | |||
| "xml2js": "^0.4.17", | |||
| "geolib": "^2.0.24" | |||
|
There should be a test to go with this, easy enough to add since there are subscription tests already in place. |
|
I'd like to change to using lodash in all new code instead of |
|
Ready to continue? |
Tweak the formatting regexps to include everything under lib. Reformat
Change SSL configuration so that if settings.ssl is set the server listens on sslport for ssl connections only and http port requests are redirected to the root of the ssl service.
Configure Express where it is constructed.
If the server is to be restarted we can not use just one DevNull, as that gets ended with first server stop() and future writes fail with write after end.
So that you don't mistake it for some demo settings.
This commit concentrates configuration handling code to config.js and breaks unrelated functionalities to separate functions. Express configuration is in the main server file, where Express is constructed. Settings handling is changed so that you can pass a configuration object to Server constructor, easing test setups. The server can now be stopped and started programmatically, paving way for restarting the server without restarting the process.
Use Travis-friendly address per travis-ci/travis-ci#1304
SubscriptionManager handles deltas' values independently: the values are pushed to Bacon buses, bus per path, by StreamBundle. When the bus's subscriptions fire SM reconstructs outgoing delta from the incoming pathvalues. Previously StreamBundle normalized pathvalues of naked properties, where path is empty, to synthesized pathvalues with 'normal' paths and matching values. The generated outgoing delta was then not naked, as it was generated from the synthesized pathvalues. This commit changes the handling so that the original, incoming normalised pathvalue is pushed to buses for paths generated from the object value's structure. Since we are pushing the normalised pathvalues from the original delta the output pathvalues match the incoming data.
sbender9
force-pushed
the
relativePosition-radius
branch
from
f605980 to
f57160e
Compare
|
Closing for new #446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.