fix: non-uppercase isrc causes duplicate songs

SilentVoid13 · Oct 13, 2024 · e19749a · e19749a
1 parent 4eb17dc
commit e19749a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/spotify/response.rs b/src/spotify/response.rs
@@ -86,7 +86,7 @@ impl TryInto<Song> for SpotifySongResponse {
             source: MusicApiType::Spotify,
             id: self.id,
             sid: None,
-            isrc: Some(self.external_ids.isrc),
+            isrc: Some(self.external_ids.isrc.to_uppercase()),
             name: self.name,
             album: Some(album),
             artists,

diff --git a/src/tidal/mod.rs b/src/tidal/mod.rs
@@ -249,7 +249,6 @@ impl MusicApi for TidalApi {
     }
 
     async fn get_playlist_songs(&self, id: &str) -> Result<Vec<Song>> {
-        dbg!("get_playlist_songs");
         let url = format!("{}/v1/playlists/{}/items", Self::API_URL, id);
         let params = json!({
             "countryCode": "US",
@@ -262,7 +261,6 @@ impl MusicApi for TidalApi {
     }
 
     async fn add_songs_to_playlist(&self, playlist: &mut Playlist, songs: &[Song]) -> Result<()> {
-        dbg!("add_songs_to_playlist");
         if songs.is_empty() {
             return Ok(());
         }
@@ -334,6 +332,9 @@ impl MusicApi for TidalApi {
             if res.data.is_empty() {
                 return Ok(None);
             }
+            dbg!(&res);
+            dbg!(&song);
+            todo!();
             let res_song: Song = res.try_into()?;
             return Ok(Some(res_song));
         }

diff --git a/src/tidal/response.rs b/src/tidal/response.rs
@@ -61,7 +61,7 @@ impl TryInto<Song> for TidalSongResponse {
             source: MusicApiType::Tidal,
             id: self.id.to_string(),
             sid: None,
-            isrc: Some(self.isrc),
+            isrc: Some(self.isrc.to_uppercase()),
             name: self.title,
             album: Some(album),
             artists,