fix some issues #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silvris
pushed a commit
that referenced
this pull request
Mar 5, 2024
* Cleaning up (#4) Cleanup * Adressed change about spaces no longer being replaced to underscores. Added a "that" to remove an ambiguity * Update data/options.yaml Combined the two sentences into one, per suggestion Co-authored-by: Nicholas Saylor <[email protected]> --------- Co-authored-by: Nicholas Saylor <[email protected]>
Silvris
pushed a commit
that referenced
this pull request
Mar 5, 2024
* Cleaning up (#4) Cleanup * Update landstalker_setup_en.md Fixed Redirect
Silvris
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Cleaning up (#4) Cleanup * Changed channel name * Changed channel name * Update docs/world maintainer.md * Update docs/world maintainer.md
Silvris
added a commit
that referenced
this pull request
Dec 31, 2024
* first pass * move to a metaclass approach * another concept for rabbits goals * ffxvi and pizza tower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The
from_anytype annotation is usuallyAny, but this type alias is for better narrowing of the generics.The default typing has been explored and discussed ArchipelagoMW#2173 and ArchipelagoMW#2899
and it looks like no type annotation is the best we can do for it. (It will inherit the type from the base class. Some type checkers will infer the type for better checking.)
The
tupleinstead oflistprotects against global mutability bugs we've seen before.__init__can turn the tuple into alistI don't know if you want to do error checking instead of the
text.get("text", "")default empty string.get_option_nameis aclassmethodin the superclass. I'm not sure whether you were trying to override that or make a new instance method. I assumed override.In general, you should prefer
isinstance(x, ...)overtype(x)(especially when this code is designed for inheritance).How was this tested?
just unit tests