New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify linoNo increment #284

Merged

rossPatton merged 1 commit into SimenB:develop from sertae:simplify-lineNo-increment

Apr 24, 2016

Collaborator

wojciechczerniak commented Apr 24, 2016

I had a problem with double increment until I realized the second one is just ignored.
There are three solutions to simplify the code:

remove second post-increment: this.cache.lineNo = lineNo
remove the first one, and use pre-increment this.cache.lineNo = ++lineNo
make it so obvious that no one ever wonders why this.cache.lineNo = lineNo + 1

I like the last one best.


          simplify linoNo increment

576f455

rossPatton merged commit e90993d into SimenB:develop

wojciechczerniak deleted the simplify-lineNo-increment branch

April 24, 2016 18:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet