Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about WeekView wrapped by SafeArea #146

Closed
porum opened this issue Nov 30, 2022 · 3 comments · Fixed by #150
Closed

Discussion about WeekView wrapped by SafeArea #146

porum opened this issue Nov 30, 2022 · 3 comments · Fixed by #150
Labels
bug Something isn't working

Comments

@porum
Copy link
Contributor

porum commented Nov 30, 2022

This library is great, but I have a little problem about WeekView. In my case, out app is landscape and fullscreen without statusbar, but weekview cannot expand to status bar.
So, whether to consider remove SafeArea.
IMG_20221130_150645

@porum
Copy link
Contributor Author

porum commented Dec 1, 2022

DayView also have the same problem.
Screenshot_2022-12-01-16-41-40-529_com calendar page example example

@PRBaraiya PRBaraiya added bug Something isn't working priority:1 Bug/Enhancement with highest priority. labels Dec 5, 2022
@PRBaraiya
Copy link
Collaborator

Thanks for pointing this out @porum. We have planned this and decided to add a bool flag to define whether safe area should be added or not. Default value of this flag will be true. because we don't want current users to face issues. We will make these changes in short time. Or you are welcome to do it as well if you want.

@porum
Copy link
Contributor Author

porum commented Dec 8, 2022

Hi @PRBaraiya, I have commit a pr to fix this bug.

@porum porum changed the title Discussion about WeekView wrapperd by SafeArea Discussion about WeekView wrapped by SafeArea Dec 9, 2022
@PRBaraiya PRBaraiya added the in progress This label defines issues that are in progress. label Jan 4, 2023
ParthBaraiya pushed a commit that referenced this issue Jan 7, 2023
@PRBaraiya PRBaraiya removed in progress This label defines issues that are in progress. priority:1 Bug/Enhancement with highest priority. labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants