Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 prevent actions if receiver is not capable of dealing with them #192

Conversation

jonasbadstuebner
Copy link
Contributor

Description

Sometimes I got errors when the receiver of these calls was unable to handle the request. This PR checks if the receiver is "healthy enough" to handle the requested call.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

#187

Copy link
Collaborator

@aditya-css aditya-css left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please ensure to cover all the usage of messageStreamController.sink.add with isClosed check? Also, please add this to changelog.

@jonasbadstuebner jonasbadstuebner force-pushed the fix-actions-on-unhealthy-targets branch from 4f9c683 to c9439b6 Compare June 18, 2024 16:46
@aditya-css aditya-css merged commit e3e154a into SimformSolutionsPvtLtd:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants