Removed warning and analyzer error

SimformSolutionsPvtLtd · Feb 22, 2023 · e543d6d · e543d6d
1 parent 3698950
commit e543d6d
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,11 @@
 ## [2.0.1] (Unreleased)
-- Add support for enabling/disabling showcase globally.
-- Added support of manual vertical tooltip position.
+- Fixed [#318](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/318) - Add support for enable/disable showcase globally.
+- Feature [#306](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/306) - Added support of manual vertical tooltip position.
 - Added PR title validation workflow
 - Fixed [#316](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/316) - Add title and description padding
+- Fixed [#330](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/330) - Overlay not showing in flutter 3.7.0
+- Fixed [#288](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/288) - Take in account view insets (such as keyboard)
+- Fixed [#334](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/334) - Move code line to resolve no context issue
 
 ## [2.0.0+1]
 - Fixed [#237](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/261) - Feature added to enable/disable default gesture of ShowcaseView child using `disableDefaultTargetGestures` parameter

diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -8,6 +8,8 @@ analyzer:
     argument_type_not_assignable: error
     invalid_assignment: error
     dead_code: warning
+    overridden_fields: ignore
+    use_key_in_widget_constructors: ignore
 
 linter:
   rules:

diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -184,7 +184,7 @@ class _MailPageState extends State<MailPage> {
                                       disableDefaultTargetGestures: true,
                                       child: GestureDetector(
                                         onTap: () =>
-                                            print('menu button clicked'),
+                                            debugPrint('menu button clicked'),
                                         child: Icon(
                                           Icons.menu,
                                           color: Theme.of(context).primaryColor,

diff --git a/lib/src/layout_overlays.dart b/lib/src/layout_overlays.dart
@@ -171,14 +171,12 @@ class _OverlayBuilderState extends State<OverlayBuilder> {
   }
 
   void addToOverlay(OverlayEntry overlayEntry) async {
-    final showCaseContext = ShowCaseWidget.of(context).context;
     if (mounted) {
-      if (Overlay.of(showCaseContext) != null) {
-        Overlay.of(showCaseContext)!.insert(overlayEntry);
-      } else {
-        if (Overlay.of(context) != null) {
-          Overlay.of(context)!.insert(overlayEntry);
-        }
+      final showCaseContext = ShowCaseWidget.of(context).context;
+      if (Overlay.maybeOf(showCaseContext) != null) {
+        Overlay.of(showCaseContext).insert(overlayEntry);
+      } else if (Overlay.maybeOf(context) != null) {
+        Overlay.of(context).insert(overlayEntry);
       }
     }
   }

diff --git a/lib/src/tooltip_widget.dart b/lib/src/tooltip_widget.dart
@@ -580,4 +580,4 @@ class _Arrow extends CustomPainter {
         oldDelegate.paintingStyle != paintingStyle ||
         oldDelegate.strokeWidth != strokeWidth;
   }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -580,4 +580,4 @@ class _Arrow extends CustomPainter { @@
             oldDelegate.paintingStyle != paintingStyle ||
             oldDelegate.strokeWidth != strokeWidth;
       }
-    }
+    }