Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ShowCaseWidgetState initializes the
anchoredOverlayKey
ininitRootWidget
after the first frame was rendered (WidgetsBinding.instance.addPostFrameCallback
). This means that theShowcase
widget'sAnchoredOverlay
will initially have thekey
property set to null.This causes unwanted behavior since when the key is eventually updated in the
AnchoredOverlay
, it will cause its child to get disposed and completely rebuilt. In my case, the child I pass into theShowcase
widget and (so theAnchoredOverlay
) is animated and disposing the child breaks its animations.I suggest that the
anchoredOverlayKey
in theShowCaseWidgetState
is initialized directly in theinitState
or if there is some reason for it to be initialized after the first frame (which I do not believe so), make it part of the_InheritedShowCaseView
and let theShowcase
widget pass the update to theAnchoredOverlay
usingShowCaseWidget.of...
.Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues