-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MER-2573] Task to create contained objectives for existing sections #4238
[MER-2573] Task to create contained objectives for existing sections #4238
Conversation
6b8d238
to
6afaaf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job 🤩!!! I just left a couple of small NITs/questions
As we discussed yesterday in the office, when I ran the task while running the app, the app crashed, so maybe we should take a look at that. I tested it with a couple more sections and works great!
65f3534
to
204903d
Compare
Based on Augusto's comment and after some debugging I noticed an Oban weird error caused by having two instances of Oban running at the same time (server running locally and the Oban instance started by the mix task). |
204903d
to
a6bda48
Compare
MER-2573
This PR is the first of three parts to create and use the new
ContainedObjectives
table. Similar toContainedPages
, this works as a quick way of knowing which objectives are attached to activities within a specific container.As part of this pull request:
contained_objectives
table and newv25_migration
field undersections
that states if the contained objectives were built for a section.mix create_contained_objectives
in the console.The remaining two PRs will include the changes for automatically building the contained objectives when a section gets created, remixed, or updated, and the new Filter By implementation on the Learning Objectives tab under the Instructor Dashboard.