[BUG FIX] Fix attempt count [MER-2616] #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliknebel
approved these changes
Oct 2, 2023
eliknebel
added a commit
that referenced
this pull request
Oct 5, 2023
* [BUGFIX][MER-2565] Fix user's full name length * [MER-2587][BUGFIX] Flashing option dropdown (#4248) * fix option dropdown flashing by implementing JS commands instead of bs-toogle * fix tests * [MER-2566] Fixes modal onmount error (#4247) * [MER-2298] Adds sort by published date (#4249) * [BUG FIX][MER-2613] floating titlebar z index bounds and sticky messages (#4261) * rework title bar so that it doesnt cover other components * fix duplicate sticky banners * [Enhancement] Better link, callout, foreign editing [MER-2469] [MER-2409] (#4258) * [Enhancement] Link editing improvements * Generalized our empty-link removal to other types * Auto format --------- Co-authored-by: marc-hughes <[email protected]> * [Enhancement] Changed error message wording on admin adaptive preview (#4257) * [BUGFIX][MER-2410] New Institution not being created after approving registration (#4256) * approve registration when setting dropdown option * add tests * fix Cancel button for review-registration-modal and decline-registration-modal * refetch institutions after approval * [Bugfix] Render bar between dates correctly (#4260) * [Bugfix] Visual connector bar on scheduler works on small date ranges * [Bugfix] Fixed dragging icon on last day of 31 day month * Auto format --------- Co-authored-by: marc-hughes <[email protected]> * [BUG FIX] fix cardinality assumption in Accounts.is_lms_user?/1 [MER-2576] (#4262) * fix cardinality assumption * simplify * update other test * [BUG FIX] [MER-2616] fix attempt count (#4263) * [MER-2618] Forgot Password link throws 500 error * [MER-2620] z-index issue between the page title and the create menu modal * [MER-2617] Codeblock text appears too small * [BUG FIX] [MER-2619] Hidden spaces in LTI Registration form values can cause 500 error on launch * [MER-2621] Fix recommended actions (#4273) * fix recommended schedule action for new course section * extend tests for recommended schedule action for new course sections * restrict pending activities count to current section resource attempts * extend test for score questions not to count attempts for same resources of other sections * [BUGFIX] [MER-2612] Scoring in assessment settings defaulting to average (#4259) * [MER-2612] Show empty value on Scoring dropdown in Assessment Settings page * [MER-2612] Add scoring_strategy_id to section resources function * [BUGFIX][MER-2570] Fix error accessing project preview (#4244) * [MER-2570] Adds fixes to render function * [MER-2570] Some corrections * addressed code review comments --------- Co-authored-by: Nicolás Cirio <[email protected]> * [BUG FIX] never show hints in graded context [MER-2624] * [BUG FIX] Remove author specific columns [MER-2623] * [BUG FIX] Empty slugs [MER-2625] * [MER-2639] Post created flash appears in all active user windows (#4283) * fix flash messages showing when other user submits a post, when other user leaves chatroom or when instructor approves users post * do not consider deleted posts in number_of_posts count and in most_recent_post * do not render 'most recent post:' if there are no posts yet * add tests for posts counts and most recent post in discussion activity filtered by discussion * [MER-2642] fix text search clear button (#4284) * added missing on clauses --------- Co-authored-by: Augusto Alonso <[email protected]> Co-authored-by: Nicolás Cirio <[email protected]> Co-authored-by: Santiago Simoncelli <[email protected]> Co-authored-by: Eli Knebel <[email protected]> Co-authored-by: Marc Hughes <[email protected]> Co-authored-by: marc-hughes <[email protected]> Co-authored-by: Gastón Abellá <[email protected]>
nicocirio
pushed a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scored activities view impl specialized the counting of page attempts for V2 sections incorrectly. It was counting total activity attempts, when all that we want is just total page attempts.