[MER-2583] Guardrails in account creation process that assure correct email formatting #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrensiegel
deleted the
MER-2583-ensure-email-formatting-in-account-creation
branch
darrensiegel
added a commit
that referenced
this pull request
Oct 11, 2023
* update runtime config check separate our torus-builder image build step * revert runtime config change * only start https server in prod if cert paths are specified * fix image names * update torus builder action * login to ghcr * try with permissions * add permissions to package job * missing dash * use ghcr.io for torus-builder * remove ghcr * rename torus-builder job * [MER-2654] Implement where you left off option (#4298) * add most_recent_visited_resource field in enrollment struct + migration * render lastest_visited_page in student dashboard, for student and for preview mode * move common get_resource_scheduled_date to Delivery Utils module * update last_visited_page in visit/6 page_livecycle.ex * fix failing tests * test get_latest_visited_page/2 * test card renders correctly in page_delivery_controller index * [MER-2583] Guardrails in account creation process that assure correct email formatting (#4292) * add email_confirmation virtual field to User schema + registration form * customize Pow flash message for email confirmation * fix failing tests due to new email_confirmation field * add tests * [FEATURE][MER-2142] Add labels to course navigation (#4300) * add labels to course navigation * Auto format * cleanup * Auto format --------- Co-authored-by: Raphael Gachuhi <[email protected]> Co-authored-by: Darren Siegel <[email protected]> --------- Co-authored-by: Eli Knebel <[email protected]> Co-authored-by: Nicolás Cirio <[email protected]> Co-authored-by: Raphael <[email protected]> Co-authored-by: Raphael Gachuhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the ticket
Screen.Recording.2023-10-09.at.11.12.57.mov