Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Sort attempts by date submitted #4327

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[BUGFIX] Sort attempts by date submitted #4327

merged 1 commit into from
Oct 20, 2023

Conversation

nicocirio
Copy link
Contributor

This PR fixes the sorting of the submitted attempts by using DateTime.before?/2 instead of directly comparing the two datetimes.

Before

Screenshot 2023-10-18 at 11 20 11

After

Screenshot 2023-10-18 at 11 25 01

gastonabella
gastonabella approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@gastonabella gastonabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@darrensiegel darrensiegel merged commit 1cd9556 into master Oct 20, 2023
@darrensiegel darrensiegel deleted the bugfix-attempts-sorted-by-date branch October 20, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonabella gastonabella gastonabella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicocirio @gastonabella @darrensiegel