[CHORE] elixir format and auto format check #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix non-deterministic test failures caused by json validation
…torus into elixir-auto-format
nicocirio
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CI check to auto format if possible and also require correct formatting in build step.
Most of the changes here are a result of simon-bot running the auto formatter.
This PR also includes a fix for a failing, non-deterministic tests for ingest_live, where the test would wait 1 second for the JSON validation to complete before checking the rendered html. Because of the validation performance issues, depending on the resources of the system and size of the digest, this could take longer than 1 second to complete and fail. I set the default of bypass JSON validation to be true and removed to toggle JSON validation, since this feature is not working correctly, we haven't kept up with the schemas, and it likely is only a burden on the system more-so than it is helpful.
Previewing the merge conflicts that will be caused in
nextgen-ux, the conflicts appear to be manageable as long as we integrate master in as soon as we land this one.