-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE][MER-2681] Redesing changes visualization publish view #4363
[FEATURE][MER-2681] Redesing changes visualization publish view #4363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes all look good.
The only thing that I think we need to change is to remove the "center alignment" of the table columns. They should all just be left aligned.
Are structural/non-structural the right terms here? I'm not sure the average user is going to know what those mean. Would Major/Minor be better since we already have prior art below explaining what those mean to the user? |
@darrensiegel @bitbldr Yes, I was guided by the ticket description to use If you think it's clearer for the user to change it to "Major"/"Minor", I will change it without problems. |
Yes, let's rename "Structural" and "Non-structural" to "Major" and "Minor" |
MER-2681
This PR redesigns the way publication changes are rendered in the
publish view
.It adds a table showing title, change type and categorization of changes.
If the categorization is
structural
, the whole row is highlighted in grey color.Feel free to suggest design changes to display the data in the table.