[FIX] Footer positioning within nav_sidebar layout #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writhe
changed the title
Writhe
changed the title
eliknebel
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes footer positioning when rendered within nav sidebar layout above "lg" breakpoint.
The issue
The layout's content slot has 200px of left-padding to accommodate the sidebar. The footer has absolute position to make it sit over its container's (seemingly unnecessary) bottom padding. That same container was missing
position: relative, so the footer'sleft: 0was at the layout's left border - underneath the sidebar.Before:
After:
[EDIT]: This does not seem related to issue 3635 after all. That issue concerns Project Overview page, which uses a different layout (also, I wasn't able to replicate it, so maybe it got fixed).
Note
In the long term, my recommendation would be to make the layout responsible for its children's positioning. Currently, the footer template contains specific positioning rules which limit its reusability. Perhaps a dedicated footer slot in the layout?