[Feature] Directed Discussion Activity [MER-1472] #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hughes
force-pushed
the
feature/MER-1472-directed-discussion-activity
branch
from
38f37c2 to
94ce39f
Compare
darrensiegel
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Really nice work! Tested locally and works well. There's a few things that we should fix, and I pointed just a couple of Elixir style things that don't need to be addressed really.
Also, when I do a "Page Preview" as an Author in the editor, I do not see anything render for the Directed Discussion. It should at least render the authored question stem, and maybe an= input that resesembles what a student would see that allows them to create a post, but it would be read only.
assets/src/components/activities/directed-discussion/discussion/DirectedDiscussion.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/activities/directed-discussion/discussion/participation-util.tsx
Show resolved
Hide resolved
marc-hughes
force-pushed
the
feature/MER-1472-directed-discussion-activity
branch
from
33ea0b6 to
94ce39f
Compare
marc-hughes
force-pushed
the
feature/MER-1472-directed-discussion-activity
branch
from
aad7131 to
dc0aa3a
Compare
darrensiegel
approved these changes
Dec 1, 2023
darrensiegel
deleted the
feature/MER-1472-directed-discussion-activity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new directed-discussion activity.
Open Question - Admins previewing a course who are not instructors can not participate. Is that ok?
Open question before we merge: Right now, I manually added an activity_registration record into my local system, what's the proper way to do that so it shows up for everyone. The ecto.rest / test.ecto.reset does seem to add it, is there an automatic process on rollouts?
2023-11-20.13-20-45.mp4