Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MER-2731] Remove max limits on Datashop download and add caching #4464

Conversation

gastonabella
Copy link
Contributor

@gastonabella gastonabella commented Nov 24, 2023

MER-2731

Second PR for improving the Datashop export feature (first PR #4459)

It introduces the following changes:

  • Process the Datashop export process in batches, showing the number of batches processed in real time.
  • Use a Cache for storing intermediate data.
  • Some UI/CSS improvements.
datashop_demo_2.mov

Copy link
Contributor

@darrensiegel darrensiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work, the caching is going to have a big impact on performance here. Just a couple of things that need to be fixed

config/runtime.exs Outdated Show resolved Hide resolved
lib/oli/analytics/datashop_export_worker.ex Outdated Show resolved Hide resolved
@darrensiegel darrensiegel merged commit 5aed474 into master Nov 27, 2023
@darrensiegel darrensiegel deleted the MER-2731-remove-max-limits-on-datashop-download-and-add-caching branch November 27, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants