[MER-2920] Extend live session plugs #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to use plug with setCurrentUser plug in module docs
gastonabella
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the ticket
Both AppSignal errors had similar root causes. In both cases, the used live plugs were expecting a
current_user/author_id, but were not handling cases where those values were not yet in the session. So, the fix was to handle those cases and redirect the user to the login page.On the other hand, the SetCtx plug was incorrectly assuming there was already a user set in the assigns and, if this plug is not used after the SetCurrentUser plug, the mentioned assigned may not exist.
The SetCtx module docs were expanded to explain this case.