[FEATURE] [MER-2904] Add missing error logging for activity editing error #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrensiegel
approved these changes
Jan 18, 2024
darrensiegel
deleted the
feature/MER-2904-add-missing-error-logging-for-activity-editing-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MER-2904
This PR aims to get and send a more accurate error message to AppSignal if an error occurs in the execution flow when editing an activity.
After analyzing the code, and trying to force all the errors that can happen in this flow, I found that it can be sent in the
send_errorfunction of theAppSignalmodule, as metadata a tuple, but the functionAppsignal.Span.set_attributedoes not allow this type of data (only allows data types such as String, integer, boolean or float), so I think it would not be receiving correctly.https://hexdocs.pm/appsignal/2.7.10/Appsignal.Span.html#set_attribute/3
Feel free to add any comments in order to get better options for logging errors in AppSignal in a more efficient and clear way.