Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] [MER-2915] Additional activity summarization only visible when answering more than once #4628

Conversation

simonchoxx
Copy link
Contributor

@simonchoxx simonchoxx commented Feb 2, 2024

MER-2915

This PR seeks to correct the error mentioned in the ticket above.

To do so, it was necessary to add to the actions that are executed when pressing the Reset button (to reset the activity) the survey_id information that ends up propagating to the Activity Attempts table in the database.

It's necessary to set the survey_id whenever the activity is reset as this data must be added to the records created for that activity in the Activity Attempts table.

This change was necessary because the Practice Activities tab should NOT show the details of the activities that are contained within a survey.

Copy link
Contributor

@gastonabella gastonabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
What do you think about adding a simple test case to the AttemptController that ensures that the survey id is correctly passed when resetting the activity?

@darrensiegel darrensiegel merged commit 7df7143 into hotfix-v0.26.3 Feb 6, 2024
5 checks passed
@darrensiegel darrensiegel deleted the bugfix/MER-2915-additional-activity-summarization-only-visible-when-answering-more-than-once branch February 6, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants