[BUG FIX] [MER-4121] Remove top-level objectives pre-filter #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonchoxx
deleted the
MER-4121-low-proficiency-skills-learning-objectives-filter-does-not-work
branch
darrensiegel
added a commit
that referenced
this pull request
Jan 21, 2025
* [FEATURE] [MER-4016] add more parameters to assignment launch page (#5279) * [FEATURE] [MER-3961] Remove Admin `Browse collab spaces` (#5276) https://eliterate.atlassian.net/browse/MER-3961 * add page termos on prologue page * fix spacing between elements to match figma desing * fix warning * consider default scoring strategy * add tests * debug auto deploy * revert workflow file * only create activity_attempts_submitted index if it does not already exist (#5283) * fix sidebar (#5285) * [FEATURE] [MER-4093] ExtenD term page cases on prologue (#5286) * extend page submission term to consider new logic * add tests * extend page submission logic + tests (#5287) Co-authored-by: Santiago Simoncelli <[email protected]> * [MER-4096] Add depot warmer environment variables to the runtime configuration (#5288) * [MER-4099] Show a time limit message when no due date is set (#5290) * [MER-4101] Show the Time Limit page term when is configured (#5291) This PR adds the "Time Limit" page term when its value is different from 0, regardless of other conditions. https://eliterate.atlassian.net/browse/MER-4101 * [MER-4105] Remove any reference to autosubmit on assessment terms displayed to student (#5294) * prep 29.1 hf branch * [MER-4121] Remove top-level objectives pre-filter (#5314) * [BUG FIX] [MER-4117] Infinite loading and errors thrown on adaptive pages (#5307) * TRIAGE-1240 * trying to run the check again * trying to run the check again * prep 29.3 * [BUG FIX] [MER-4138] Fix launch issues (#5332) * db transaction, add lti_institution_id * bump version * bump version * update unit test * Auto format --------- Co-authored-by: darrensiegel <[email protected]> * prep 29.4 * [BUG FIX] [MER-4138] Fix maybe create sub (#5333) * full remove maybe_create_unique_sub * set sub explicity, rename test module conflict from 29.3 change * keep sub in memory * prep 29.5 * [CHORE] [MER-0000] Convert Hotfix v0.29.2 to v0.29.5 (#5334) * prep 29.2 * [BUG FIX] [MER-4124] broken internal page links Co-authored-by: Anders Weinstein <[email protected]> * [BUG FIX] [MER-4126] Fix targeted retake one question at a time * [BUG FIX] [MER-4118] Improve Student Assessment Submit Terms * [BUG FIX] [MER-4120] One at a time setting can prevent submissions * [BUG FIX] [MER-4123] Fix high progress low proficiency filter (#5325) * [MER-4123] Fix filter for only pages * [MER-4123] Adds test * [BUG FIX] [MER-4123] Fix high progress low proficiency filter * [BUG FIX] [MER-3507] Require instructor login when accessing course section information as account admin * [BUG FIX] [MER-4127] Fix Learning Objectives Proficiency Distribution Hover Boundary (#5328) Fixed boundary miscalculation of Proficiency Distribution tooltip and increased stacking context for proper visibility. See: https://eliterate.atlassian.net/browse/MER-4127 * [BUG FIX] [MER-4011] Real chem course section creation loads indefinitely * bump --------- Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Santiago Simoncelli <[email protected]> Co-authored-by: Gastón Abellá <[email protected]> Co-authored-by: Nicolás Cirio <[email protected]> Co-authored-by: Martin Manelli <[email protected]> * [BUG FIX] [MER-4135] Cannot export some projects (#5330) * prep 29.2 * [BUG FIX] [MER-4124] broken internal page links Co-authored-by: Anders Weinstein <[email protected]> * [BUG FIX] [MER-4126] Fix targeted retake one question at a time * [BUG FIX] [MER-4118] Improve Student Assessment Submit Terms * [BUG FIX] [MER-4120] One at a time setting can prevent submissions * [BUG FIX] [MER-4123] Fix high progress low proficiency filter (#5325) * [MER-4123] Fix filter for only pages * [MER-4123] Adds test * [BUG FIX] [MER-4123] Fix high progress low proficiency filter * [BUG FIX] [MER-3507] Require instructor login when accessing course section information as account admin * [BUG FIX] [MER-4127] Fix Learning Objectives Proficiency Distribution Hover Boundary (#5328) Fixed boundary miscalculation of Proficiency Distribution tooltip and increased stacking context for proper visibility. See: https://eliterate.atlassian.net/browse/MER-4127 * [BUG FIX] [MER-4011] Real chem course section creation loads indefinitely * consider children: nil case --------- Co-authored-by: Darren Siegel <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Santiago Simoncelli <[email protected]> Co-authored-by: Gastón Abellá <[email protected]> Co-authored-by: Martin Manelli <[email protected]> * [FEATURE] [MER-4139] Restore user progress tool (#5335) * admin tool to restore affected progress * ensure true user enrolled in section * refine conflict graded page handling * add warning, and display user details in tabular form * finalize, docs * Auto format --------- Co-authored-by: darrensiegel <[email protected]> --------- Co-authored-by: Nicolás Cirio <[email protected]> Co-authored-by: Santiago Simoncelli <[email protected]> Co-authored-by: Francisco-Castro <[email protected]> Co-authored-by: Darren Siegel <[email protected]> Co-authored-by: Devesh Tiwari <[email protected]> Co-authored-by: darrensiegel <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Gastón Abellá <[email protected]> Co-authored-by: Martin Manelli <[email protected]>
rgachuhi
added a commit
that referenced
this pull request
Feb 6, 2025
* [FEATURE] [MER-4016] add more parameters to assignment launch page (#5279) * [FEATURE] [MER-3961] Remove Admin `Browse collab spaces` (#5276) https://eliterate.atlassian.net/browse/MER-3961 * add page termos on prologue page * fix spacing between elements to match figma desing * fix warning * consider default scoring strategy * add tests * debug auto deploy * revert workflow file * only create activity_attempts_submitted index if it does not already exist (#5283) * fix sidebar (#5285) * [FEATURE] [MER-4093] ExtenD term page cases on prologue (#5286) * extend page submission term to consider new logic * add tests * extend page submission logic + tests (#5287) Co-authored-by: Santiago Simoncelli <[email protected]> * [MER-4096] Add depot warmer environment variables to the runtime configuration (#5288) * [MER-4099] Show a time limit message when no due date is set (#5290) * [MER-4101] Show the Time Limit page term when is configured (#5291) This PR adds the "Time Limit" page term when its value is different from 0, regardless of other conditions. https://eliterate.atlassian.net/browse/MER-4101 * [MER-4105] Remove any reference to autosubmit on assessment terms displayed to student (#5294) * prep 29.1 hf branch * [MER-4121] Remove top-level objectives pre-filter (#5314) * [BUG FIX] [MER-4117] Infinite loading and errors thrown on adaptive pages (#5307) * TRIAGE-1240 * trying to run the check again * trying to run the check again * prep 29.3 * [BUG FIX] [MER-4138] Fix launch issues (#5332) * db transaction, add lti_institution_id * bump version * bump version * update unit test * Auto format --------- Co-authored-by: darrensiegel <[email protected]> * prep 29.4 * [BUG FIX] [MER-4138] Fix maybe create sub (#5333) * full remove maybe_create_unique_sub * set sub explicity, rename test module conflict from 29.3 change * keep sub in memory * prep 29.5 * [CHORE] [MER-0000] Convert Hotfix v0.29.2 to v0.29.5 (#5334) * prep 29.2 * [BUG FIX] [MER-4124] broken internal page links Co-authored-by: Anders Weinstein <[email protected]> * [BUG FIX] [MER-4126] Fix targeted retake one question at a time * [BUG FIX] [MER-4118] Improve Student Assessment Submit Terms * [BUG FIX] [MER-4120] One at a time setting can prevent submissions * [BUG FIX] [MER-4123] Fix high progress low proficiency filter (#5325) * [MER-4123] Fix filter for only pages * [MER-4123] Adds test * [BUG FIX] [MER-4123] Fix high progress low proficiency filter * [BUG FIX] [MER-3507] Require instructor login when accessing course section information as account admin * [BUG FIX] [MER-4127] Fix Learning Objectives Proficiency Distribution Hover Boundary (#5328) Fixed boundary miscalculation of Proficiency Distribution tooltip and increased stacking context for proper visibility. See: https://eliterate.atlassian.net/browse/MER-4127 * [BUG FIX] [MER-4011] Real chem course section creation loads indefinitely * bump --------- Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Santiago Simoncelli <[email protected]> Co-authored-by: Gastón Abellá <[email protected]> Co-authored-by: Nicolás Cirio <[email protected]> Co-authored-by: Martin Manelli <[email protected]> * [BUG FIX] [MER-4135] Cannot export some projects (#5330) * prep 29.2 * [BUG FIX] [MER-4124] broken internal page links Co-authored-by: Anders Weinstein <[email protected]> * [BUG FIX] [MER-4126] Fix targeted retake one question at a time * [BUG FIX] [MER-4118] Improve Student Assessment Submit Terms * [BUG FIX] [MER-4120] One at a time setting can prevent submissions * [BUG FIX] [MER-4123] Fix high progress low proficiency filter (#5325) * [MER-4123] Fix filter for only pages * [MER-4123] Adds test * [BUG FIX] [MER-4123] Fix high progress low proficiency filter * [BUG FIX] [MER-3507] Require instructor login when accessing course section information as account admin * [BUG FIX] [MER-4127] Fix Learning Objectives Proficiency Distribution Hover Boundary (#5328) Fixed boundary miscalculation of Proficiency Distribution tooltip and increased stacking context for proper visibility. See: https://eliterate.atlassian.net/browse/MER-4127 * [BUG FIX] [MER-4011] Real chem course section creation loads indefinitely * consider children: nil case --------- Co-authored-by: Darren Siegel <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Santiago Simoncelli <[email protected]> Co-authored-by: Gastón Abellá <[email protected]> Co-authored-by: Martin Manelli <[email protected]> * [FEATURE] [MER-4139] Restore user progress tool (#5335) * admin tool to restore affected progress * ensure true user enrolled in section * refine conflict graded page handling * add warning, and display user details in tabular form * finalize, docs * Auto format --------- Co-authored-by: darrensiegel <[email protected]> * prep 29.6 * [BUG FIX] [MER-4131] | Dig into chem labs simulations * [BUG FIX] [MER-4178] [MER-4186] Fix required survey issues (#5363) * fix required survey issues * Auto format --------- Co-authored-by: darrensiegel <[email protected]> --------- Co-authored-by: Nicolás Cirio <[email protected]> Co-authored-by: Eli Knebel <[email protected]> Co-authored-by: Santiago Simoncelli <[email protected]> Co-authored-by: Francisco-Castro <[email protected]> Co-authored-by: Darren Siegel <[email protected]> Co-authored-by: Devesh Tiwari <[email protected]> Co-authored-by: darrensiegel <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Anders Weinstein <[email protected]> Co-authored-by: Gastón Abellá <[email protected]> Co-authored-by: Martin Manelli <[email protected]> Co-authored-by: Raphael Gachuhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: MER-4121
This PR removes the top-level objectives pre-filter. With this change, we now target all objectives.
Screen.Recording.2024-12-19.at.12.50.18.PM.mov