Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websocket cleanup policy #253

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Add websocket cleanup policy #253

merged 5 commits into from
Oct 1, 2024

Conversation

frankier
Copy link
Contributor

@frankier frankier commented Sep 5, 2024 •
edited
Loading

The idea here is that

  1. People can customize the websocket cleanup behavior in Bonito
  2. Those wanting to manage their own websockets can make use of the same pluggable behaviour including using the default policy from Bonito.

Builds on #247

@frankier frankier mentioned this pull request Sep 5, 2024
Open
@SimonDanisch
Copy link
Owner

Thank you, this looks good, besides my comment ;) We may want to have more tests for this as well.

@frankier
Copy link
Contributor Author

Done and done

@frankier
Copy link
Contributor Author

frankier commented Oct 1, 2024

@SimonDanisch Ping. Ready to merge?

@SimonDanisch
Copy link
Owner

Thank you, looks good :)

@SimonDanisch SimonDanisch merged commit 637afc0 into SimonDanisch:master Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonDanisch SimonDanisch Awaiting requested review from SimonDanisch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankier @SimonDanisch