SolverProxDDP: remove solver parameter rho_
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifoldFR
force-pushed
the
topic/proxddp-remove-rho
branch
from
217cf79 to
5a3f766
Compare
ManifoldFR
force-pushed
the
topic/proxddp-remove-rho
branch
from
67b5df5 to
2bcbb15
Compare
|
@edantec I will let you assess if you are okay with this change, so you can adjust your codebase accordingly. |
ManifoldFR
changed the title
rho_rho_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
rho_parameter of the solver, which used to be the primal proximal regularization parameter but was not used anymore for a while. This is an API BREAKING change.