Change formatting of exceptions, using variadic macro and type-erased implementation #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifoldFR
force-pushed
the
change-formatting-of-exceptions
branch
7 times, most recently
from
fa741fd to
2db2c32
Compare
ManifoldFR
changed the title
+ remove include of <array> header, use raw C-style array + better headline
formatting function + Make ALIGATOR_RUNTIME_ERROR, ALIGATOR_WARNING to variadic macros + Calling either macro does not require including fmt/format.h + Change include of fmt/color.h to fmt/base.h in exceptions.h (reduces size of include) + Add src/utils/exceptions.cpp
+ move include to fwd.hpp header + remove use of exception macros in gar + move math exceptions to fwd.hpp
ManifoldFR
force-pushed
the
change-formatting-of-exceptions
branch
from
937ea32 to
54be0d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the
ALIGATOR_RUNTIME_ERRORandALIGATOR_WARNINGmacros, and cuts down on the number of LOC pulled into the headeraligator/utils/exceptions.hppwhich is included everywhere.src/utils/exceptions.cppwhich implements type-erased formatting function (following this suggestion in fmtlib's docs)Merge after #229