Cybernetics Trait Changes #1828
Conversation
Signed-off-by: Raikyr0 <[email protected]>
Signed-off-by: Raikyr0 <[email protected]>
github-actions
bot
added
Status: Needs Review
|
The changelog is a special section of a PR description that's used to generate entries for the in game menu and discord. Please rewrite your entries for a non developer audience. |
Signed-off-by: Raikyr0 <[email protected]>
Signed-off-by: Raikyr0 <[email protected]>
* Corpsman Glasses Added Corpsman Glasses to the game, added it to Corpsmans lockers, and added a crafting recipe for them. * Corpsman Glasses Added Corpsman Glasses to the game, added it to Corpsmans lockers, and added a crafting recipe for them. * Corpsman Glasses Added Corpsman Glasses to the game, added it to Corpsmans lockers, and added a crafting recipe for them. * Corpsman Glasses Added Corpsman Glasses to the game, added it to Corpsmans lockers, and added a crafting recipe for them.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| Genetic: -0.07 | ||
| Brute: -0.35 | ||
| Burn: -0.35 | ||
| Airloss: -0.25 |
There was a problem hiding this comment.
Lets replace the Airloss group with maybe -0.07 Bloodloss (individual damage, not a group). The pre-buff bloodloss healing was actually one of its best types to be fair.
| @@ -521,7 +507,7 @@ | |||
| action: ActionSericulture | |||
| productionLength: 2 | |||
| entityProduced: MaterialWebSilk1 | |||
| hungerCost: 4 | |||
| hungerCost: 1 | |||
There was a problem hiding this comment.
If you really want to buff this, consider making this trait also add the tag needed by web crafting recipes? Actually I kinda forgot if we ever put in a TraitAddTag, but it would be kinda trivial to add I think.
Signed-off-by: VMSolidus <[email protected]>
WalkthroughThe changes update several trait configurations across multiple files. In the locale file, the "Striking Calluses" trait now increases unarmed damage by 2 instead of 1, while the "Spinarette" trait description has been simplified. Additionally, cosmetic name updates were applied to the "LightAmplification" and "ThermographicVision" traits. In the character item group configuration, several CyberEyes-related traits have been removed, leaving only "CyberEyes." In the physical traits file, several requirements were removed and various numerical parameters—such as damage caps, point costs, and hunger costs—were adjusted. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Resources/Prototypes/Traits/physical.yml (1)
510-510: Drastically reduced hunger cost for Spinarette.The hunger cost has been reduced from 4 to 1, making this trait far more practical for field deployment. The trailing space after the value should be removed for proper YAML formatting.
- hungerCost: 1 + hungerCost: 1🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 510-510: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Resources/Locale/en-US/traits/traits.ftl(3 hunks)Resources/Prototypes/CharacterItemGroups/Generic/mindormachine.yml(0 hunks)Resources/Prototypes/Traits/physical.yml(8 hunks)
💤 Files with no reviewable changes (1)
- Resources/Prototypes/CharacterItemGroups/Generic/mindormachine.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
Resources/Prototypes/Traits/physical.yml
[error] 510-510: trailing spaces
(trailing-spaces)
🔇 Additional comments (11)
Resources/Locale/en-US/traits/traits.ftl (4)
386-386: Striking Calluses damage boost increased to 2.This change increases the unarmed damage bonus from 1 to 2, making this cybernetic enhancement considerably more potent for colonists engaged in hand-to-hand combat. The corresponding change in physical.yml confirms this enhancement.
394-394: Simplified Spinarette description for improved clarity.The description has been streamlined by removing the metabolic cost explanation. This aligns with the reduced hunger cost in the prototype file (from 4 to 1), making the trait more appealing to potential recruits.
532-534: Improved naming consistency for cybernetic ocular enhancements.The naming convention has been standardized to "Cyber-Eyes: [Module Name]" format, which creates a more cohesive classification system for all cybernetic vision enhancements. This will reduce confusion during deployment briefings.
536-538: Standardized naming for Thermographic Scanner module.Similar to the Light Amplification module, this change maintains consistency in the cybernetics classification system. The Sol Alliance might prefer their disorganized naming schemes, but in the Biesel Republic, we value clear communication protocols.
Resources/Prototypes/Traits/physical.yml (7)
483-483: Increased unarmed damage bonus for Striking Calluses.The damage bonus has been doubled from 1 to 2, providing a substantial combat advantage. This change properly implements the updated description from the locale file and makes this cybernetic enhancement considerably more valuable for our operatives.
488-488: Balanced the point cost for Spinarette.The trait cost has been reduced from -4 to -3 points, making it more accessible to colonists. This adjustment is reasonable given the reduction in hunger cost implemented in line 510.
725-725: Extended CyberEyesOmni access to Command personnel.The Cyber-Eyes Omnihud premium suite is now available to Command department personnel in addition to Security. This is a logical extension as command staff require comprehensive situational awareness.
818-818: Reduced point cost for Thermographic Vision.The cost has been significantly reduced from -8 to -4 points, making thermal vision more accessible to field operatives. This balances the trait with similar vision enhancements and aligns with our directive to improve lesser-used traits.
861-861: Increased healing cap for NaniteAutoRepairBots.The damage cap for synthetic operatives has been increased from 200 to 250, providing IPCs with better self-repair capabilities. This is a moderate and reasonable increase that improves synthetic unit survivability without making them overpowered.
1006-1006: Extended OmniEyesModule access to Command personnel.Similar to the change for CyberEyesOmni, this modification grants IPC Command staff access to the comprehensive vision suite. This ensures consistent trait availability across both organic and synthetic personnel in leadership positions.
1055-1055: Reduced point cost for ThermographicVisionModule.The cost reduction from -8 to -4 points mirrors the change made to the organic version of this trait, maintaining parity between organic and synthetic operatives. This balanced approach ensures that neither group has an unfair advantage in tactical scenarios.
Resources/Prototypes/CharacterItemGroups/Generic/mindormachine.yml
Outdated
Show resolved
Hide resolved
….yml Signed-off-by: VMSolidus <[email protected]>
Description
Changes/buffs to Cybernetic Traits.
Some lesser used traits get some love, while some other stuff gets some logical re-balancing.
Feel free to point out if some shitcode is broken or need explaining.
TODO
Changelog
🆑
Summary by CodeRabbit
New Features
Documentation
Chores