Add EE Specific Ores To Lavaland #1864
Conversation
github-actions
bot
added
Status: Needs Review
WalkthroughThe changes introduce a series of new tungsten ore vein entities and integrate them into various gameplay systems. New entities for tungsten variants have been added for asteroids and wall structures, including a modification to an existing chromite entity. A new biome marker layer for tungsten ore is defined, along with an updated salvage loot entry that guarantees tungsten drops. Furthermore, the Lavaland ore list has been expanded with new ore entries and the reactivation of a previously commented-out ore. Changes
Sequence Diagram(s)sequenceDiagram
participant GE as Game Engine
participant BG as Biome Generator
participant OT as Ore Templates Loader
participant EF as Entity Factory
GE->>BG: Initiate biome generation
BG->>OT: Load ore templates (including OreTungsten)
OT-->>BG: Return tungsten mappings and parameters
BG->>EF: Instantiate tungsten ore entities (Asteroid & Walls)
EF-->>BG: Confirm entity creation
BG-->>GE: Biome generation complete
sequenceDiagram
participant GE as Game Engine
participant LS as Loot System
GE->>LS: Trigger salvage event
LS->>LS: Check guaranteed loot entries (OreTungsten)
LS-->>GE: Return OreTungsten salvage loot
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🔭 Outside diff range comments (2)
Resources/Prototypes/Entities/Structures/Walls/asteroid.yml (2)
2488-2508: 🛠️ Refactor suggestion
⚠️ Potential issueWallRockChromiteTungsten: Suffix Inconsistency Detected!
The tungsten variant for the chromite group is misnamed withsuffix: Copper. Update this tosuffix: Tungstenand adjust any sprite references fromrock_copperto the appropriate tungsten variant to ensure consistency with the new ore type.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 2499-2499: too many spaces inside brackets
(brackets)
[error] 2499-2499: too many spaces inside brackets
(brackets)
[error] 2501-2501: too many spaces inside brackets
(brackets)
[error] 2501-2501: too many spaces inside brackets
(brackets)
[error] 2503-2503: too many spaces inside brackets
(brackets)
[error] 2503-2503: too many spaces inside brackets
(brackets)
[error] 2505-2505: too many spaces inside brackets
(brackets)
[error] 2505-2505: too many spaces inside brackets
(brackets)
2884-2905: 🛠️ Refactor suggestion
⚠️ Potential issueWallRockAndesiteTungsten: Verify Visual Consistency!
This andesite tungsten entity correctly usessuffix: Tungstenin its header, but its sprite configuration still ends withrock_copper. Please update the sprite state to something that reflects tungsten (e.g.rock_tungsten) so the visuals match the ore’s identity.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 2896-2896: too many spaces inside brackets
(brackets)
[error] 2896-2896: too many spaces inside brackets
(brackets)
[error] 2898-2898: too many spaces inside brackets
(brackets)
[error] 2898-2898: too many spaces inside brackets
(brackets)
[error] 2900-2900: too many spaces inside brackets
(brackets)
[error] 2900-2900: too many spaces inside brackets
(brackets)
[error] 2902-2902: too many spaces inside brackets
(brackets)
[error] 2902-2902: too many spaces inside brackets
(brackets)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
Resources/Prototypes/Entities/Structures/Walls/asteroid.yml(7 hunks)Resources/Prototypes/Procedural/biome_ore_templates.yml(1 hunks)Resources/Prototypes/Procedural/salvage_loot.yml(1 hunks)Resources/Prototypes/_Lavaland/Procedural/lavaland_planets.yml(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: YAML Linter
Resources/Prototypes/Procedural/biome_ore_templates.yml
[error] 36-36: No EntityPrototype found with id WallRockChromiteCopper
🪛 YAMLlint (1.35.1)
Resources/Prototypes/Entities/Structures/Walls/asteroid.yml
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
[error] 2896-2896: too many spaces inside brackets
(brackets)
[error] 2896-2896: too many spaces inside brackets
(brackets)
[error] 2898-2898: too many spaces inside brackets
(brackets)
[error] 2898-2898: too many spaces inside brackets
(brackets)
[error] 2900-2900: too many spaces inside brackets
(brackets)
[error] 2900-2900: too many spaces inside brackets
(brackets)
[error] 2902-2902: too many spaces inside brackets
(brackets)
[error] 2902-2902: too many spaces inside brackets
(brackets)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Test Packaging
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (3)
Resources/Prototypes/_Lavaland/Procedural/lavaland_planets.yml (1)
30-38: Ore List Expanded Exemplarily!
The ore list now includes new entries (OreBananium, OreAluminium, OreCopper, OreTungsten, OreLead, OreNormality) to enrich Lavaland. Please verify that these IDs match the prototypes defined in other modules (e.g. Entities and Biome Templates).Resources/Prototypes/Procedural/salvage_loot.yml (1)
235-242: Tungsten Salvage Loot Entry Added!
The new salvage loot block for OreTungsten is configured withguaranteed: trueand correctly references theBiomeMarkerLootprototype. Ensure the corresponding prototype exists and is in sync with the biome marker configuration.Resources/Prototypes/Procedural/biome_ore_templates.yml (1)
189-202: New Tungsten Biome Marker Layer Integration!
The added biome marker layer for OreTungsten properly maps multiple rock types (AsteroidRock, WallRock, WallRockBasalt, WallRockChromite, WallRockSand, WallRockSnow) to their tungsten variants. Verify that the referenced entity IDs (e.g. AsteroidRockTungsten, WallRockTungsten, etc.) are defined correctly in the Entities file.
| - type: entity | ||
| id: AsteroidRockTungsten | ||
| parent: AsteroidRock | ||
| description: An ore vein rich with wolframite. | ||
| suffix: Copper | ||
| components: | ||
| - type: OreVein | ||
| oreChance: 1.0 | ||
| currentOre: OreTungsten | ||
| - type: Sprite | ||
| layers: | ||
| - state: rock_asteroid | ||
| - map: [ "enum.EdgeLayer.South" ] | ||
| state: rock_asteroid_south | ||
| - map: [ "enum.EdgeLayer.East" ] | ||
| state: rock_asteroid_east | ||
| - map: [ "enum.EdgeLayer.North" ] | ||
| state: rock_asteroid_north | ||
| - map: [ "enum.EdgeLayer.West" ] | ||
| state: rock_asteroid_west | ||
| - state: rock_copper | ||
|
|
||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
AsteroidRockTungsten: Incorrect Suffix and Sprite State!
The new asteroid tungsten ore entity is intended to represent an ore vein rich with wolframite, yet it still uses suffix: Copper and references rock_copper for its sprite. This mislabelling could confuse both players and subsequent systems. Please update these to reflect tungsten (for example, use suffix: Tungsten and set the sprite state to something like rock_tungsten).
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
| - type: entity | ||
| id: WallRockTungsten | ||
| parent: WallRock | ||
| description: An ore vein rich with wolframite. | ||
| suffix: Copper | ||
| components: | ||
| - type: OreVein | ||
| oreChance: 1.0 | ||
| currentOre: OreTungsten | ||
| - type: Sprite | ||
| layers: | ||
| - state: rock | ||
| - map: [ "enum.EdgeLayer.South" ] | ||
| state: rock_south | ||
| - map: [ "enum.EdgeLayer.East" ] | ||
| state: rock_east | ||
| - map: [ "enum.EdgeLayer.North" ] | ||
| state: rock_north | ||
| - map: [ "enum.EdgeLayer.West" ] | ||
| state: rock_west | ||
| - state: rock_copper | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
WallRockTungsten: Suffix and Sprite Mismatch!
The wall variant for tungsten ore currently misuses suffix: Copper and ends its sprite definition with rock_copper. Adjust these so that the entity clearly represents tungsten—for example, use suffix: Tungsten and update sprite layers accordingly (e.g. rock_tungsten).
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
| - type: entity | ||
| id: WallRockBasaltTungsten | ||
| parent: WallRockBasalt | ||
| description: An ore vein rich with wolframite. | ||
| suffix: Copper | ||
| components: | ||
| - type: OreVein | ||
| oreChance: 1.0 | ||
| currentOre: OreTungsten | ||
| - type: Sprite | ||
| layers: | ||
| - state: rock_wall | ||
| - map: [ "enum.EdgeLayer.South" ] | ||
| state: rock_wall_south | ||
| - map: [ "enum.EdgeLayer.East" ] | ||
| state: rock_wall_east | ||
| - map: [ "enum.EdgeLayer.North" ] | ||
| state: rock_wall_north | ||
| - map: [ "enum.EdgeLayer.West" ] | ||
| state: rock_wall_west | ||
| - state: rock_copper | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
WallRockBasaltTungsten: Mismatched Suffix and Visuals!
This basalt tungsten entity is incorrectly labelled with suffix: Copper and utilizes a sprite state of rock_copper. Correct these identifiers to better reflect its tungsten nature (suggested: suffix: Tungsten and a sprite state like rock_tungsten).
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
| - type: entity | ||
| id: WallRockSnowTungsten | ||
| parent: WallRockSnow | ||
| description: An ore vein rich with wolframite. | ||
| suffix: Copper | ||
| components: | ||
| - type: OreVein | ||
| oreChance: 1.0 | ||
| currentOre: OreTungsten | ||
| - type: Sprite | ||
| layers: | ||
| - state: rock_snow | ||
| - map: [ "enum.EdgeLayer.South" ] | ||
| state: rock_snow_south | ||
| - map: [ "enum.EdgeLayer.East" ] | ||
| state: rock_snow_east | ||
| - map: [ "enum.EdgeLayer.North" ] | ||
| state: rock_snow_north | ||
| - map: [ "enum.EdgeLayer.West" ] | ||
| state: rock_snow_west | ||
| - state: rock_copper | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
WallRockSnowTungsten: Inconsistent Labeling!
The snow variant for tungsten still carries the suffix: Copper and references rock_copper in its sprite layers. Update these to use tungsten-specific naming (e.g. suffix: Tungsten and a sprite state such as rock_tungsten) to maintain consistency across ore types.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
| - type: entity | ||
| id: WallRockSandTungsten | ||
| parent: WallRockSand | ||
| description: An ore vein rich with wolframite. | ||
| suffix: Tungsten | ||
| components: | ||
| - type: OreVein | ||
| oreChance: 1.0 | ||
| currentOre: OreTungsten | ||
| - type: Sprite | ||
| layers: | ||
| - state: rock_sand | ||
| - map: [ "enum.EdgeLayer.South" ] | ||
| state: rock_sand_south | ||
| - map: [ "enum.EdgeLayer.East" ] | ||
| state: rock_sand_east | ||
| - map: [ "enum.EdgeLayer.North" ] | ||
| state: rock_sand_north | ||
| - map: [ "enum.EdgeLayer.West" ] | ||
| state: rock_sand_west | ||
| - state: rock_copper | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
WallRockSandTungsten: Sprite State Issue!
While the entity designation is correct with suffix: Tungsten, the sprite layer erroneously references rock_copper. Please amend the sprite state to reflect tungsten, for example to rock_tungsten.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
Resources/Prototypes/Entities/Structures/Walls/asteroid.yml(7 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
Resources/Prototypes/Entities/Structures/Walls/asteroid.yml
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
[error] 2521-2521: too many spaces inside brackets
(brackets)
[error] 2521-2521: too many spaces inside brackets
(brackets)
[error] 2523-2523: too many spaces inside brackets
(brackets)
[error] 2523-2523: too many spaces inside brackets
(brackets)
[error] 2525-2525: too many spaces inside brackets
(brackets)
[error] 2525-2525: too many spaces inside brackets
(brackets)
[error] 2527-2527: too many spaces inside brackets
(brackets)
[error] 2527-2527: too many spaces inside brackets
(brackets)
[error] 2918-2918: too many spaces inside brackets
(brackets)
[error] 2918-2918: too many spaces inside brackets
(brackets)
[error] 2920-2920: too many spaces inside brackets
(brackets)
[error] 2920-2920: too many spaces inside brackets
(brackets)
[error] 2922-2922: too many spaces inside brackets
(brackets)
[error] 2922-2922: too many spaces inside brackets
(brackets)
[error] 2924-2924: too many spaces inside brackets
(brackets)
[error] 2924-2924: too many spaces inside brackets
(brackets)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Test Packaging
- GitHub Check: YAML Linter
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (7)
Resources/Prototypes/Entities/Structures/Walls/asteroid.yml (7)
499-520: AsteroidRockTungsten: Incorrect Sprite State!
Ahoy, officer! The asteroid tungsten ore entity is meant to reflect a vein rich with wolframite, yet its final sprite state is set to"rock_copper". This mislabeling misguides our visual representation in battle. Please update it to something like"rock_tungsten"to honor its true nature.- - state: rock_copper + - state: rock_tungsten🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
922-943: WallRockTungsten: Sprite Inconsistency!
Captain, our wall-mounted tungsten ore is mistakenly displaying the copper sprite ("rock_copper") instead of a tungsten-specific one. This error could lead to confusion on the field of battle. Kindly adjust the sprite state to"rock_tungsten".- - state: rock_copper + - state: rock_tungsten🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 934-934: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 936-936: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 938-938: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
[error] 940-940: too many spaces inside brackets
(brackets)
1319-1340: WallRockBasaltTungsten: Visual Mismatch!
Our basalt tungsten entity ends its sprite layers with"rock_copper", which does not do justice to its tungsten lineage. Please update the final sprite state to"rock_tungsten"so that our ore stands true to its description.- - state: rock_copper + - state: rock_tungsten🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1331-1331: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1333-1333: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1335-1335: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
[error] 1337-1337: too many spaces inside brackets
(brackets)
1716-1737: WallRockSnowTungsten: Sprite Discrepancy!
By the stars, the snowy tungsten entity is still adorned with"rock_copper"in its sprite layer. This undermines its intended tungsten identity amidst the ice. Change the sprite state to"rock_tungsten"for consistent visuals across our ranks.- - state: rock_copper + - state: rock_tungsten🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1728-1728: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1730-1730: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1732-1732: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
[error] 1734-1734: too many spaces inside brackets
(brackets)
2112-2133: WallRockSandTungsten: Incorrect Visual Reference!
In our sandy outcroppings, the tungsten ore is erroneously represented by the copper sprite ("rock_copper"). For the honor of our furnaces, please update this to"rock_tungsten"so that the ore truly reflects its wolframite essence.- - state: rock_copper + - state: rock_tungsten🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2124-2124: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2126-2126: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2128-2128: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
[error] 2130-2130: too many spaces inside brackets
(brackets)
2509-2530: WallRockChromiteTungsten: Sprite State Error!
Within the chromite cadre, the tungsten variant has inadvertently retained the copper sprite ("rock_copper"). This misrepresentation may lead to misidentification in the field. Kindly replace it with"rock_tungsten"to maintain consistency.- - state: rock_copper + - state: rock_tungsten🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 2521-2521: too many spaces inside brackets
(brackets)
[error] 2521-2521: too many spaces inside brackets
(brackets)
[error] 2523-2523: too many spaces inside brackets
(brackets)
[error] 2523-2523: too many spaces inside brackets
(brackets)
[error] 2525-2525: too many spaces inside brackets
(brackets)
[error] 2525-2525: too many spaces inside brackets
(brackets)
[error] 2527-2527: too many spaces inside brackets
(brackets)
[error] 2527-2527: too many spaces inside brackets
(brackets)
2906-2927: WallRockAndesiteTungsten: Visual Incongruity!
Our andesite tungsten entity appears to be in the Sol Alliance’s colors—displaying"rock_copper"instead of the befitting"rock_tungsten". Updating the sprite layer accordingly ensures that the ore’s identity remains true to its tungsten nature.- - state: rock_copper + - state: rock_tungsten🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 2918-2918: too many spaces inside brackets
(brackets)
[error] 2918-2918: too many spaces inside brackets
(brackets)
[error] 2920-2920: too many spaces inside brackets
(brackets)
[error] 2920-2920: too many spaces inside brackets
(brackets)
[error] 2922-2922: too many spaces inside brackets
(brackets)
[error] 2922-2922: too many spaces inside brackets
(brackets)
[error] 2924-2924: too many spaces inside brackets
(brackets)
[error] 2924-2924: too many spaces inside brackets
(brackets)
| - map: [ "enum.EdgeLayer.South" ] | ||
| state: rock_asteroid_south | ||
| - map: [ "enum.EdgeLayer.East" ] | ||
| state: rock_asteroid_east | ||
| - map: [ "enum.EdgeLayer.North" ] | ||
| state: rock_asteroid_north | ||
| - map: [ "enum.EdgeLayer.West" ] |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
YAML Formatting: Extraneous Spaces in Bracket Lists
Our YAML static analysis tools have flagged multiple instances where there appear to be too many spaces inside bracketed lists (for example, lines like
- map: [ "enum.EdgeLayer.South" ]
may benefit from tighter spacing, e.g.,
- map: ["enum.EdgeLayer.South"]
While these warnings can sometimes be false positives, please verify that our YAML style guidelines are met across these ranges. Consistent formatting will help keep our code as shipshape as our fleet!
Also applies to: 934-940, 1331-1337, 1728-1734, 2124-2130, 2521-2527, 2918-2924
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 511-511: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 513-513: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 515-515: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
[error] 517-517: too many spaces inside brackets
(brackets)
Description
EE Specific ores weren't spawning on Lavaland, also added an ore vein for Tungsten.
Changelog
🆑
Summary by CodeRabbit