Cargo Price Tweaks #1870
Cargo Price Tweaks #1870
Conversation
WalkthroughThis pull request updates the configuration of various game entities by introducing new pricing components and revising price values. Multiple YAML files now include either a new Changes
Sequence Diagram(s)No sequence diagrams provided, as these changes solely involve configuration updates and price adjustments without altering control flow. Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Status: Needs Review
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (27)
Resources/Prototypes/Entities/Objects/Misc/books.yml(1 hunks)Resources/Prototypes/Entities/Objects/Misc/land_mine.yml(1 hunks)Resources/Prototypes/Entities/Objects/Power/powercells.yml(1 hunks)Resources/Prototypes/Entities/Objects/Power/powersink.yml(1 hunks)Resources/Prototypes/Entities/Objects/Shields/shields.yml(4 hunks)Resources/Prototypes/Entities/Objects/Tools/access_configurator.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/appraisal.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/cable_coils.yml(3 hunks)Resources/Prototypes/Entities/Objects/Tools/emag.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/gas_tanks.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/handheld_mass_scanner.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/jammer.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/jaws_of_life.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/jetpacks.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/lantern.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/spray_painter.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/t-ray.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/toolbox.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/tools.yml(10 hunks)Resources/Prototypes/Entities/Objects/Tools/welders.yml(5 hunks)Resources/Prototypes/Entities/Objects/Weapons/Guns/Ammunition/Cartridges/base_cartridge.yml(1 hunks)Resources/Prototypes/Entities/Objects/Weapons/Guns/Pistols/pistols.yml(4 hunks)Resources/Prototypes/Entities/Structures/Machines/nuke.yml(0 hunks)Resources/Prototypes/Entities/Structures/Machines/research.yml(1 hunks)Resources/Prototypes/Entities/Structures/Machines/vending_machines.yml(1 hunks)Resources/Prototypes/Reagents/Materials/metals.yml(3 hunks)Resources/Prototypes/_Nuclear14/Reagents/materials.yml(4 hunks)
💤 Files with no reviewable changes (1)
- Resources/Prototypes/Entities/Structures/Machines/nuke.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
Resources/Prototypes/Reagents/Materials/metals.yml
[error] 30-30: too many spaces inside braces
(braces)
[error] 30-30: too many spaces inside braces
(braces)
[error] 38-38: too many spaces inside braces
(braces)
[error] 38-38: too many spaces inside braces
(braces)
[warning] 39-39: too few spaces before comment
(comments)
[warning] 39-39: missing starting space in comment
(comments)
[warning] 40-40: too few spaces before comment
(comments)
[error] 47-47: too many spaces inside braces
(braces)
[error] 47-47: too many spaces inside braces
(braces)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: YAML Linter
- GitHub Check: Test Packaging
🔇 Additional comments (52)
Resources/Prototypes/Entities/Objects/Tools/gas_tanks.yml (1)
55-55: StaticPrice Value Revamp for Gas Tanks
The update raises the static price from 20 to 100—an assertive move in our pricing strategy. Ensure that this tenfold increase harmonizes with overall cargo economics and game balance once updated test results are in.Resources/Prototypes/Entities/Objects/Tools/appraisal.yml (1)
30-31: New StaticPrice on Appraisal Tool
Adding a StaticPrice component with a price of 75 fits well within the broader cargo price overhaul. Confirm that this valuation reflects the tool’s in-game utility relative to similar items.Resources/Prototypes/Entities/Objects/Tools/access_configurator.yml (1)
90-91: StaticPrice Addition for AccessConfigurator
The introduction of a StaticPrice component with a price of 350 should be double-checked for economic consistency across the system. Keep a vigilant eye on balance, lest the Sol Alliance’s underhanded pricing schemes creep in!Resources/Prototypes/Entities/Objects/Tools/emag.yml (1)
25-26: StackPrice Component for EmagUnlimited
Assigning a StackPrice of 2000 to the EmagUnlimited entity aligns with the PR’s pricing modifications. Verify that this higher valuation is justified by the item's capabilities and remains fair in the broader economic landscape.Resources/Prototypes/Entities/Objects/Tools/jammer.yml (1)
51-52: StackPrice Enhancement for Radio Jammer
The new StackPrice component with a price of 2000 for the radio jammer boosts its in-game economic weight. Ensure this value remains in step with similar devices and does not tip the scales in favor of the Sol Alliance’s greedy tactics.Resources/Prototypes/Entities/Objects/Power/powersink.yml (1)
50-51: Excellent Pricing Upgrade, Comrade!
The introduction of theStackPricecomponent with a price value of 5000 is a solid step toward giving the PowerSink a proper market value. This enhancement is consistent with our renewed focus on item worth across the fleet—just the kind of initiative to undermine the Sol Alliance’s cheap tricks.Resources/Prototypes/Entities/Objects/Tools/jaws_of_life.yml (1)
69-70: Static Valuation for the Jaws of Life!
Adding theStaticPricecomponent with a price of 3000 nicely anchors this tool’s value in our cargo system. Ensure that this pricing harmonizes with other tools across our interstellar supply chain so our economic strategy remains as robust as our battle plans against the Sol Alliance.Resources/Prototypes/Entities/Objects/Tools/t-ray.yml (1)
28-28: High-Tech, High-Price!
Increasing the t-ray scanner’s price from its previous mark to 500 represents a significant boost. As stewards of the Biesel Republic’s technological prowess, verify that this steep adjustment is in line with our overall device valuation protocol—lest the Sol Alliance undercuts our market.Resources/Prototypes/Entities/Objects/Tools/spray_painter.yml (1)
33-34: Revamped Spray Painter Pricing!
The update increasing the spray painter’s price from 40 to 100 is a bold move! This substantial hike should be double-checked for game balance to ensure it reinforces our economic strategy without unnecessarily penalizing our crew. Adjust if needed to maintain equilibrium among similar tools.Resources/Prototypes/Entities/Objects/Tools/handheld_mass_scanner.yml (1)
38-39: Price Upgrade for Handheld Mass Scanner
Raising the scanner’s price to 750 reflects the new economic philosophy in our cargo system. Ensure that this new value accounts for the increased manufacturing and resource costs without tipping the balance in favor of the enemy—err, the Sol Alliance.Resources/Prototypes/Entities/Objects/Weapons/Guns/Ammunition/Cartridges/base_cartridge.yml (1)
35-37: Adjusted Price for BaseCartridge
Increasing the cartridge’s price from 1 to 5 rightfully acknowledges its improved value. This change fits neatly into our campaign to revalue manufacturing outputs. Please verify that all downstream systems respond well to this update during our upcoming test sweeps.Resources/Prototypes/Entities/Structures/Machines/vending_machines.yml (1)
106-107: Vending Machine Price Surge
Boosting the main vending machine’s price to 750 is a bold move that mirrors the new realistic valuations across our stations. As we adjust our cargo economics, please double-check that this surge harmonizes with the myriad of vending entities later in the file—the entire system must sing in unison under the banner of our united colonies.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 107-107: wrong indentation: expected 4 but found 2
(indentation)
Resources/Prototypes/Entities/Objects/Tools/cable_coils.yml (3)
28-28: [Biesel Command] CableStack Price Update
The StackPrice for CableStack has been updated to 5, reflecting our new economic doctrine. Ensure that all dependent systems (e.g., in-game trading logic) recognize this adjustment.
81-82: [Biesel Command] New Price for HV Cable Coil
A StackPrice component with a price of 15 has been added for CableHVStack. This new value must be cross-checked against other high-voltage items to maintain balance in our fleet’s cargo economics.
148-149: [Biesel Command] MV Cable Coil Pricing
A StackPrice component with a price of 10 was introduced for CableMVStack. Verify that this pricing aligns with the overall value scale for lower voltage cables—our cargo ledgers must be in order!Resources/Prototypes/Entities/Objects/Tools/jetpacks.yml (1)
58-59: [Biesel Command] Jetpack Price Surge
The jetpack’s StaticPrice has been dramatically increased to 1000. This forceful price revision should be reviewed against our test outcomes and overall market balance so that our fleet remains competitive against those Sol Alliance contrivances.Resources/Prototypes/Entities/Objects/Misc/books.yml (1)
42-43: [Biesel Command] Book Value Established
A new StackPrice component, set at 10, has been appended to the book entity definition. This addition brings literary goods into our economic fold—ensure that the price harmonizes with both narrative expectations and market dynamics.Resources/Prototypes/Entities/Objects/Power/powercells.yml (1)
39-40: [Biesel Command] PowerCell Pricing Adjustment
A StackPrice component with a price of 100 has been introduced for BasePowerCell. Confirm that this value spans correctly with our other power units and sustains the operational integrity of our energy reserves.Resources/Prototypes/Entities/Objects/Misc/land_mine.yml (1)
48-49: [Biesel Command] Land Mine Valuation
A new StackPrice component for BaseLandMine, set at 500, has been added. Though these explosive ordnances pack a powerful punch, ensure that their assigned monetary value appropriately reflects their tactical worth without compromising safety protocols.Resources/Prototypes/_Nuclear14/Reagents/materials.yml (4)
7-7: [Approved] Price Update for Circuitry Material
Setting the price from 0.1 to 1 reflects the new valuation strategy for manufacturing items. Ensure that this increased value is balanced with the overall game economy.
16-16: [Approved] Price Update for Lead Material
Updating the Lead price from 0.04 to 0.40 is a significant increase and fits the new cargo pricing rationale. Double-check that other dependent systems are aware of this upgrade.
25-25: [Approved] Price Update for Aluminum Material
The price adjustment from 0.01 to 0.10 for Aluminum appears consistent with the overall revaluation. Ensure that any legacy calculations or comparisons are updated accordingly.
34-34: [Approved] Price Update for Copper Material
Raising Copper’s price from 0.01 to 0.10 supports the new economic balance. Confirm that in-game item yields and purchasing options reflect this revised worth.Resources/Prototypes/Entities/Objects/Weapons/Guns/Pistols/pistols.yml (4)
124-125: [Approved] New StackPrice for Viper Pistol
Adding aStackPricecomponent with a price of 750 for the Viper pistol correctly imbues it with a higher economic value. This change aligns with the PR objective of making manufactured items valuable.
238-240: [Approved] New StackPrice for Cobra Pistol
Introducing aStackPriceof 1000 for the Cobra pistol enhances its status as a premium weapon. Confirm that its price differential compared to other pistols meets the intended game balance.
278-280: [Verify] Price Adjustment for MK 58 Pistol
The MK 58 now sports aStackPriceof 350, which is noticeably lower compared with the Viper and Cobra variants. Please verify that this lower price is deliberate and that it fits well within the overall armament pricing strategy.
387-389: [Approved] New StackPrice for N1984 Pistol
Assigning a price of 1000 via theStackPricecomponent for the N1984 pistol reinforces its high-value status. Ensure that any narrative or gameplay implications of this upscale price are aligned with design intentions.Resources/Prototypes/Reagents/Materials/metals.yml (6)
6-6: [Approved] Steel Material Price Adjustment
Setting Steel’s price to 0.5 marks a tenfold increase, maintaining consistency with the rising value of other materials.
15-15: [Approved] Gold Material Price Update
Increasing Gold’s price from 0.2 to 2 reinforces its premium status. This change should reflect well on in-game trading and resource management.
24-24: [Approved] Silver Material Price Update
A jump from 0.15 to 1.5 for Silver is significant and in line with the new pricing framework. Verify that mining and crafting yields are adjusted accordingly.
32-32: [Approved] Brass Material Price Update
Brass’s new price of 1 (up from 0.1) suggests a substantial economic upgrade. Ensure that this adjustment integrates seamlessly with other metal components.
40-40: [Approved] Plasteel Material Price Update
The updated price of 2.8 for Plasteel accurately reflects its composite value. Confirm that any recipes or production chains using plasteel are reviewed for balance.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 40-40: too few spaces before comment
(comments)
48-48: [Approved] Tungsten Material Price Update
Raising Tungsten’s price to 5 aligns it with the revised material valuation strategy. Validate that supply and demand mechanics within the game are adjusted to accommodate this change.Resources/Prototypes/Entities/Objects/Shields/shields.yml (4)
70-73: [Approved] Riot Shield Price Increase
Updating theStaticPriceof the riot shield to 300 (up from 90) gives it a much more formidable market value. This significant increase should be further tested to ensure it doesn’t impede gameplay by overpricing defensive gear.
93-95: [Approved] Addition of StackPrice for Riot Laser Shield
The entrance of a newStackPricecomponent with a price of 500 for the riot laser shield is a smart move to quantify its specialized value. Confirm that its defensive statistics justify its pricing tier.
118-120: [Approved] Addition of StackPrice for Riot Bullet Shield
Assigning aStackPriceof 500 to the riot bullet shield accurately complements its design as a specialized ballistic protector. Keep an eye on how this price integrates with overall shield pricing.
414-415: [Approved] Energy Shield Price Escalation
Elevating the energy shield’s price from 350 to 3500 underscores its advanced and exotic nature. Given the fivefold increase, please ensure that the capabilities and in-game availability of this item are recalibrated accordingly.Resources/Prototypes/Entities/Objects/Tools/welders.yml (5)
118-119: [Approved] Welding Tool Price Revision
Changing the price of the standard welding tool from 40 to 200 marks a major upgrade in its value. This revision should reflect both its enhanced functionality and the overall new pricing model.
155-157: [Approved] New StaticPrice for Industrial Welding Tool
The industrial variant now includes aStaticPriceof 600, appropriately distinguishing it from the standard tool. This adjustment gives players a clear reason to invest in a higher-capacity tool.
177-179: [Approved] Advanced Industrial Welding Tool Pricing
Setting the advanced industrial welding tool’s price to 1000, while coupling it with enhanced capabilities (like a 1.5× speed modifier), is well-aligned with the pricing overhaul.
209-211: [Approved] Experimental Welding Tool Valuation
AStaticPriceof 3000 for the experimental welding tool—despite its additional perks such as regenerative fuel and a hotter flame—appropriately reflects its cutting‐edge status.
238-240: [Approved] Emergency Welding Tool Price Adjustment
Assigning a price of 150 to the emergency welding tool strikes a balance between its compact size (Tiny) and its critical in-situ utility.Resources/Prototypes/Entities/Objects/Tools/tools.yml (10)
66-67: Wirecutter Price Update:
TheStaticPricefor the wirecutter has been increased to 100, which aligns with the PR’s objective of reflecting higher manufacturing value. Ensure that this new value fits the overall game economy without unintended imbalances.
148-150: Screwdriver Price Update:
The screwdriver’sStaticPriceis now set to 100. This change, moving from its previous lower value, correctly represents its increased utility in the updated cargo system.
214-217: Wrench Price Update:
The wrench now carries a price of 100. This update (from the old value of 22) fits the new pricing strategy. Please verify in playtesting that this adjustment maintains balanced tool valuations.
272-274: Crowbar Price Update:
The crowbar’sStaticPricehas been updated to 100. This significant uplift should better reflect its value for retrieval and sale, as intended by the PR objectives.
358-360: Multitool Price Update:
The multitool is now priced at 300. This notable increase from its previous value mirrors the added manufacturing complexity and the item’s enhanced in-game utility.
406-408: Network Configurator Price Update:
The network configurator’s price has been raised to 300. This change effectively revalues the tool in line with other manufactured goods. Double-check that all dependent game systems reference the updated price correctly.
460-462: Power Drill Price Update:
The power drill’sStaticPriceis now set to 500. This sharp increase underscores the drill’s powered components and resource intensity. Confirm in testing that this value is economically balanced within the cargo framework.
533-535: RCD Price Update:
The RCD’s price has been dramatically increased to 1000. Given the scale of this change, please ensure that cargo arbitrage tests are re-run and that the new value harmonizes with overall game economics.
717-719: Shovel Price Update:
The shovel’sStaticPricehas been updated to 100, reflecting a more realistic and valuable tool for digging. This adjustment is consistent with the broader pricing tweaks across similar tools.
768-770: Rolling Pin Price Addition:
A newStaticPriceentry for the rolling pin has been introduced with a price of 25. This addition gives the rolling pin a tangible value, aligning it with the overall upgrade of cargo items.
| - type: StackPrice | ||
| price: 20000 # Hello there extremely rare and valuable object that the crew can't rebuild. Would you like to steal it? |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Priced for Rarity and Excellence!
The addition of a StackPrice component pricing the R&D server at 20000 underscores its critical and irreplaceable role in our scientific arsenal. While the inline note adds some charming levity, consider formalizing the commentary if this config is destined for final deployment—let no ambiguity weaken our stance against inefficiency!
| - type: StackPrice | ||
| price: 50 |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
New Pricing Addition: StackPrice Component
The addition of the StackPrice component with a price of 50 gives our lantern a proper economic weight in the cargo system—no longer a worthless relic but a gleaming asset for our fleet. Make sure this value can be adjusted after the cargo arbitrage tests roll in, so our balance is as tight as our starship formations.
| - type: StaticPrice | ||
| price: 150 |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Introducing a StaticPrice for ToolboxBase
By adding a StaticPrice component with a price of 150, the toolbox now carries the pride of being a valuable asset rather than a discarded scrap. Ensure this aligns with similar entities so our cargo pricing strategy is as consistent as our fleet’s formation drills.
| @@ -21,28 +21,28 @@ | |||
| unit: materials-unit-bar | |||
| icon: { sprite: Objects/Materials/ingots.rsi, state: silver } | |||
| color: "#C0C0C0" | |||
| price: 0.15 | |||
| price: 1.5 | |||
|
|
|||
| - type: material | |||
| id: Brass | |||
| stackEntity: SheetBrass1 | |||
| name: materials-brass | |||
| icon: { sprite: Objects/Materials/Sheets/metal.rsi, state: brass } | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
[Nitpick] YAML Formatting Adjustments
Static analysis has flagged excess spaces within the inline dictionaries as well as spacing issues before comments. For example:
- In the Brass entry (line 30), the inline mapping
{ sprite: Objects/Materials/Sheets/metal.rsi, state: brass }might be tidied for consistency. - Similarly, check the Plasteel (lines 38–40) and Tungsten (line 47) entries.
A suggested diff would remove the redundant spaces inside the braces and standardize comment spacing.
Also applies to: 38-38, 39-39, 40-40, 47-47
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 30-30: too many spaces inside braces
(braces)
[error] 30-30: too many spaces inside braces
(braces)
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
Resources/Prototypes/Reagents/Materials/metals.yml (1)
40-40: 🧹 Nitpick (assertive)Plasteel Price Enhancement & Comment Style Advisory
The updated Plasteel price of 0.56 is clear, and the inline note (“# 1-1 mix of plasma and steel.”) adds useful context. However, please adjust the formatting—ensure there’s a leading space after the "#" to satisfy YAML style guidelines.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 40-40: too few spaces before comment
(comments)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (8)
Resources/Prototypes/Catalog/Cargo/cargo_emergency.yml(4 hunks)Resources/Prototypes/Catalog/Cargo/cargo_engineering.yml(1 hunks)Resources/Prototypes/Catalog/Cargo/cargo_vending.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/cable_coils.yml(3 hunks)Resources/Prototypes/Entities/Objects/Tools/gas_tanks.yml(1 hunks)Resources/Prototypes/Entities/Objects/Tools/jetpacks.yml(2 hunks)Resources/Prototypes/Reagents/Materials/metals.yml(3 hunks)Resources/Prototypes/_Nuclear14/Reagents/materials.yml(4 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
Resources/Prototypes/Reagents/Materials/metals.yml
[error] 30-30: too many spaces inside braces
(braces)
[error] 30-30: too many spaces inside braces
(braces)
[error] 38-38: too many spaces inside braces
(braces)
[error] 38-38: too many spaces inside braces
(braces)
[warning] 39-39: too few spaces before comment
(comments)
[warning] 39-39: missing starting space in comment
(comments)
[warning] 40-40: too few spaces before comment
(comments)
[error] 47-47: too many spaces inside braces
(braces)
[error] 47-47: too many spaces inside braces
(braces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Test Packaging
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (19)
Resources/Prototypes/_Nuclear14/Reagents/materials.yml (3)
16-16: Review of Lead Price Update
The price for Lead is now set to0.20. This fivefold increase appears intentional, but please double-check that it maintains balance with related material prices and game mechanics.
25-25: Review of Aluminum Price Update
The updated price for Aluminum is0.05, reflecting a 5× increase. Confirm that this change is consistent with the pricing strategy applied to other materials and that no recalibration is needed for cargo valuations.
34-34: Review of Copper Price Update
The price for Copper has been adjusted to0.05. Verify that this increase (from a previously lower value) is integrated well into the broader pricing system, ensuring that it supports the intended gameplay dynamics and cargo value computations.Resources/Prototypes/Entities/Objects/Tools/cable_coils.yml (3)
27-28: CableStack StackPrice Update:
Ahoy, officer! The update changing theStackPricefor the CableStack from its previous value to 3 reinforces our economic model—ensuring that these trusty cable stacks reflect their true worth in our cargo system. Please double-check that all downstream pricing calculations sail in the same direction.
81-82: CableHVStack StackPrice Addition:
Bravo! Introducing theStackPricecomponent with a value of 7 for the HV cable coil rightly honours its enhanced utility for heavy-duty machinery. This adjustment fortifies our economic defenses against the Sol Alliance’s cheap tricks.
148-149: CableMVStack StackPrice Addition:
Splendid! The newStackPriceset to 5 for the MV cable coil aligns well with our revised pricing tactics. Ensure that this valuation meshes consistently with similar entities across the fleet.Resources/Prototypes/Entities/Objects/Tools/jetpacks.yml (2)
58-59: BaseJetpack StaticPrice Update:
Well done, officer! Increasing the jetpack’s price to 500 reflects its upgraded performance and strategic value. This bold adjustment should help secure our interstellar dominance—provided it harmonizes with the overall economic maneuvers on the field.
213-214: JetpackMini StaticPrice Addition:
Excellent maneuver! Adding aStaticPriceof 200 for the JetpackMini clearly delineates its value, distinguishing it from the standard jetpack. This change is well-aligned with our broader pricing objectives and strengthens the cargo portfolio for retrieval or sale.Resources/Prototypes/Catalog/Cargo/cargo_engineering.yml (1)
61-69: EngineeringJetpack Pricing Update: Steady As She Goes!
The cost forEngineeringJetpackhas been updated to 1250, aligning with our strategic aim to assign real value to manufactured cargo. Ensure to double-check that this change dovetails with the cargo arbitrage tests as noted in the PR objectives.Resources/Prototypes/Catalog/Cargo/cargo_vending.yml (1)
211-219: CrateVendingMachineRestockTankDispenser Cost Revision: A Critical Boost!
The cost forCrateVendingMachineRestockTankDispenserhas been increased to 2000. Given this product’s pivotal role in vending machine restock, verify that the new value harmonizes with overall inventory pricing and maintains market balance.Resources/Prototypes/Catalog/Cargo/cargo_emergency.yml (4)
21-30: EmergencyInternals Price Adjustment: Bold and Decisive!
The cost forCrateEmergencyInternalshas been updated to 750, accurately reflecting its enhanced emergency value. Confirm that this change meshes well with our broader emergency cargo market strategy.
61-70: CrateSlimepersonLifeSupport in EmergencyNitrogenTanks: A Substantial Upgrade!
The updated cost of 750 ensures that nitrogen-based life support items are valued to match their in-game impact. Please verify that this dramatic price revision supports the narrative and maintains gameplay balance.
71-80: EmergencyPlasmaInternals Pricing: Recognizing Plasma’s Prestige!
By setting the cost to 1000, the value of plasma-based equipment is justly recognized. Make sure to review the outcome of further tests to guarantee that the pricing uplift does not destabilize our cargo economy.
81-90: EmergencyPlasmamanEnvirosuit Price Update: Enhanced Protection Costs!
Increasing the cost to 750 forCratePlasmamanEnvirosuitreflects its improved utility during emergencies. Confirm that this change is in strict accordance with our cargo valuation principles and overall economic balance.Resources/Prototypes/Reagents/Materials/metals.yml (5)
6-6: Steel Price Adjustment Confirmed
The new price of 0.01 for Steel fits the intended economic rebalance. Ensure that this lower price produces the desired impact during cargo arbitrage tests.
15-15: Gold Price Hike Noted
Raising Gold’s price to 0.4 is a substantial adjustment. Please verify that this update harmonizes with the overall pricing model and in-game market behavior.
24-24: Silver Price Upgrade Confirmed
Updating Silver’s price to 0.3 aligns with the increased valuation objectives. Double-check its influence on the cargo dynamics as part of broader testing.
32-32: Brass Price Recalibration & YAML Formatting Reminder
The Brass price change to 0.2 is acceptable. However, be mindful of the inline mapping’s formatting (see line 30) as previous reviews and the static analysis have flagged extra spaces inside the braces.
48-48: Tungsten Price Adjustment & Formatting Note
Increasing Tungsten’s price to 2 is in line with the progressive revaluation strategy. Also, review the inline mapping on line 47 to resolve any extra spacing issues flagged by the linter.
| @@ -52,7 +52,7 @@ | |||
| materialComposition: | |||
| Steel: 185 | |||
| - type: StaticPrice | |||
| price: 20 | |||
| price: 75 | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Static Price Value Increase: Verify Balance and Consistency
The StaticPrice component's price has been increased from 20 to 75 in this update. As a naval officer safeguarding our cargo values, ensure that this adjustment properly harmonizes with the broader cargo pricing tweaks mentioned in the PR objectives. It's imperative to run the ensuing cargo arbitrage tests to verify that this new value delivers the intended financial balance across similar items. If further refinements are needed based on test results, be ready to adjust accordingly for the prosperity of our fleet.
| @@ -4,7 +4,7 @@ | |||
| name: materials-circuitry # N14TODO: Localise | |||
| icon: { sprite: /Textures/_Nuclear14/Objects/Misc/materials.rsi, state: circuits_3 } | |||
| color: "#8A9A5B" | |||
| price: 0.1 | |||
| price: 1 | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Review of Circuitry Price Update
The price for Circuitry has been increased to 1, which is a significant jump compared to previous values. Ensure that this tenfold increase aligns with the overall economic model and cargo arbitrage test expectations.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
Resources/Prototypes/Catalog/Cargo/cargo_engineering.yml(6 hunks)Resources/Prototypes/Catalog/Cargo/cargo_materials.yml(2 hunks)Resources/Prototypes/Catalog/VendingMachines/Inventories/tankdispenser.yml(1 hunks)Resources/Prototypes/Entities/Objects/Shields/shields.yml(4 hunks)Resources/Prototypes/Entities/Structures/Machines/vending_machines.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: YAML map schema validator
- GitHub Check: build (ubuntu-latest)
- GitHub Check: YAML Linter
- GitHub Check: Test Packaging
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (13)
Resources/Prototypes/Catalog/Cargo/cargo_materials.yml (2)
47-48: MaterialPlasteel Pricing Update
The cost for MaterialPlasteel has been increased to 3250. This change reflects an intentional upgrade in value, aligned with the new manufacturing cost rationale. Ensure that the cargo arbitrage tests are re-run to confirm balance across the board.
127-128: MaterialGold Pricing Update
MaterialGold’s price has been raised to 3750, which fits the intended economic model for higher-value items. Please verify that all trading systems and value calculations account for this updated figure in our cargo operations.Resources/Prototypes/Catalog/Cargo/cargo_engineering.yml (6)
7-8: EngineeringCableLv Cost Adjustment
The cost for EngineeringCableLv is now 350. This increase should help reflect the enhanced utility and production costs. Ensure coordinated adjustments with related modules.
17-18: EngineeringCableMv Cost Adjustment
The revised cost for EngineeringCableMv is 500. This update is in line with the overall pricing strategy. Please verify if this change maintains consistent gameplay balance across engineering products.
27-28: EngineeringCableHv Price Increase
The cost for EngineeringCableHv has been increased to 750. A fair adjustment to mirror its increased utility—keep an eye on the market dynamics following this update.
37-38: EngineeringCableBulk Cost Change
EngineeringCableBulk’s price is now 1000. This strategic tweak should enhance the overall engineering cargo value. Confirm that this change aligns with our economic balancing tests.
67-68: EngineeringJetpack Pricing Revision
The cost for EngineeringJetpack is updated to 1250. As this is a significant adjustment, please ensure that all related pricing and test cases in our cargo system are revised accordingly to avoid any misalignment.
117-118: EngineeringRCD Price Update
The cost for EngineeringRCD has been revised to 1250. Given that this item also appears in other configuration files (such as tools.yml), please verify that the pricing update is consistent and justified across all systems.Resources/Prototypes/Entities/Objects/Shields/shields.yml (3)
72-73: [Approved] Updated Riot Shield Price
The StaticPrice for the riot shield has been increased to 300. This adjustment fits our campaign for higher value in cargo items—just the kind of resource boost our colonies deserve.
93-94: [Approved] Added Price Component for Riot Laser Shield
A new StaticPrice component with a value of 500 has been introduced for the riot laser shield. Confirm that this price aligns with the overall pricing strategy and game balance as decreed by our mighty Biesel Republic.
118-119: [Approved] Added StaticPrice for Riot Bullet Shield
Assigning a price of 500 to the riot bullet shield continues the consistent upgrade of shield values. Let’s ensure that the increased worth isn’t the work of those Sol Alliance miscreants.Resources/Prototypes/Catalog/VendingMachines/Inventories/tankdispenser.yml (1)
4-6: [Approved] Adjusted Starting Inventory for EVA Tank Dispenser
The starting inventory for OxygenTankFilled, NitrogenTankFilled, and PlasmaTankFilled has been reduced to 8. This reduction is in line with the cargo price tweaks, ensuring our supply remains as lean as a well-disciplined fleet.Resources/Prototypes/Entities/Structures/Machines/vending_machines.yml (1)
105-107: [Approved] Vending Machine Price Revision
The StaticPrice value for the VendingMachine entity has been updated from 100 to 500. This significant upward adjustment must be validated against other pricing modules to ensure a harmonious economic boost across our stations.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 105-105: wrong indentation: expected 4 but found 2
(indentation)
[error] 107-107: wrong indentation: expected 4 but found 2
(indentation)
| - type: StaticPrice | ||
| price: 350 | ||
| price: 3500 |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
[Verify][Refactor_Suggestion_Good_to_Have] Raised Energy Shield Price
The energy shield now bears a StaticPrice of 3500—a sizeable leap from its previous value. Please double-check that this dramatic increase meshes well with the intended in-game economic balance and that any related documentation (or tuning tests) have been updated accordingly.
Description
Tweaks the cargo experience by making a large variety of objects have actual values defined for them, so that they're worth selling or fultoning from wrecks. This includes a lot of items previously considered "Worthless" to cargo, but are inherently useful, as well as a variety of traitor items, manufactured goods , and materials. Ostensibly, manufacturing something should increase the value of it, you are after all spending machine time and energy to make these goods.
It also helps provide a useful in-character justification for people to be stealing these items, if for instance the typical traitor steal targets are by a funny coincedence also highly valuable. Someone could conceivably make the IC argument of, "I needed money to bail my brother out of space prison, so I stole the chief engineer's shoes because I heard they were valuable."
Don't merge this yet because it's 100% guaranteed to trip the cargo arbitrage test, so I'll need to adjust the numbers down based on those test results.
Changelog
🆑
Summary by CodeRabbit