Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AHelp Sound Improvements #585

Merged
merged 3 commits into from
Aug 2, 2024
Merged

AHelp Sound Improvements #585

merged 3 commits into from
Aug 2, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

Description

I don't like the bwoink.
I also don't like being notified about the thing I'm staring at.

If anyone has better quality sounds to suggest, I might use those instead.

Media

Different sounds

2024-07-23_00-45-28.mp4

Ignore sounds when looking

2024-07-23_00-56-09.mp4

Changelog

🆑

  • tweak: The AdminHelp sound has changed to three that play under different circumstances

@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Feature Creation of or significant changes to a feature labels Jul 23, 2024
@github-actions github-actions bot added Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jul 23, 2024
@SimpleStation14 SimpleStation14 changed the title ahelp sound improvements Ahelp Sound Improvements Jul 23, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Ahelp Sound Improvements AHelp Sound Improvements Jul 23, 2024
@DangerRevolution
Copy link
Contributor

shouldn't this have an admin CL?

@DEATHB4DEFEAT
Copy link
Member Author

shouldn't this have an admin CL?

No, this affects everyone and we still don't have admin CLs on the bot.

DangerRevolution
DangerRevolution approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the noise

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jul 23, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT added the Status: Needs Discussion Must be discussed label Jul 23, 2024
@DangerRevolution DangerRevolution self-requested a review July 29, 2024 05:52
DangerRevolution

This comment was marked as spam.

Sign in to view

@VMSolidus VMSolidus merged commit 6b86a6d into Simple-Station:master Aug 2, 2024
16 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 2, 2024
@SimpleStation14
Automatic Changelog Update (#585)
49c944d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket

@Peptide90 Peptide90 Awaiting requested review from Peptide90

Assignees

@DEATHB4DEFEAT DEATHB4DEFEAT

Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DEATHB4DEFEAT @DangerRevolution @VMSolidus