-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rj/refactor unit tests #109
base: main
Are you sure you want to change the base?
Conversation
…est in test_build
deploy still needs work because many cases are not consistent or don't work.
pytests are failing on github worker because spark sessions are crashing (likely due to OOM or something). runs fine on local machine. need to try bottlenecking the tasks going to spark submit or just disabling parallel tasks |
…s to see errors on runners.
changes besides unittests:
|
…solution. needed to use patch number 0 always.
@pytest.mark.parametrize("language", ["python", "scala"]) | ||
@pytest.mark.parametrize("command", [build, build_v2]) | ||
def test_build_path_pipeline_filter(self, language, command): | ||
project_path = self.python_project_path if language == "python" else self.scala_project_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: maybe we can make this a method in IsolatedRepoTestCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, will do
major changes: