Bugfix/#256 #259
Bugfix/#256 #259
Conversation
| ValidateTypesMatching(comparableValue); | ||
|
|
||
| var maxValue = ConvertToIComparable(MaxValue); | ||
| var comparableValue = (IComparable)value; |
There was a problem hiding this comment.
if value is not IComparable you will get cast exception. Need to check it for IComparable and add a test for that case.
There was a problem hiding this comment.
I think I won’t be able to test this because the constructor does not accept values except string, int, double
There was a problem hiding this comment.
You have "public MaxAttribute(Type type, string maxValue"
So you can pass wrong type for test:
[Min(typeof(object), "12.5")]
public object Param { get; set; }
Check can be done in constructor.
There was a problem hiding this comment.
Ok. what kind of exception i need to throw?
There was a problem hiding this comment.
ArgumentException.
"type is not IComparable, Actual type: {type.Name}"
| ValidateTypesMatching(comparableValue); | ||
|
|
||
| var minValue = ConvertToIComparable(MinValue); | ||
| var comparableValue = (IComparable)value; |
There was a problem hiding this comment.
if value is not IComparable you will get cast exception. Need to check it for IComparable and add a test for that case.
No description provided.