Remove PHP4 constructors

Signed-off-by: Dillon-Brown <[email protected]>
SinergiaTIC · Mar 26, 2021 · 4ee7a70 · 4ee7a70
1 parent ee25525
commit 4ee7a70
Show file tree

Hide file tree

Showing 427 changed files with 904 additions and 5,795 deletions.
diff --git a/ModuleInstall/ModuleInstaller.php b/ModuleInstall/ModuleInstaller.php
@@ -78,19 +78,7 @@ public function __construct()
         $this->extensions = $extensions;
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function ModuleInstaller()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
 
     /*

diff --git a/ModuleInstall/PackageManager/ListViewPackages.php b/ModuleInstall/PackageManager/ListViewPackages.php
@@ -51,19 +51,7 @@ public function __construct()
         parent::__construct();
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function ListViewPackages()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
 
     /**

diff --git a/ModuleInstall/PackageManager/PackageController.php b/ModuleInstall/PackageManager/PackageController.php
@@ -53,21 +53,6 @@ public function __construct()
          $this->_pm = new PackageManager();
      }
 
-     /**
-      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-      */
-     public function PackageController()
-     {
-         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-         if (isset($GLOBALS['log'])) {
-             $GLOBALS['log']->deprecated($deprecatedMessage);
-         } else {
-             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-         }
-         self::__construct();
-     }
-
-
      public function performBasicSearch()
      {
          $json = getJSONobj();

diff --git a/ModuleInstall/PackageManager/PackageManager.php b/ModuleInstall/PackageManager/PackageManager.php
@@ -63,19 +63,7 @@ public function __construct()
         $this->upload_dir = empty($GLOBALS['sugar_config']['upload_dir']) ? 'upload' : rtrim($GLOBALS['sugar_config']['upload_dir'], '/\\');
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function PackageManager()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
 
     public function initializeComm()

diff --git a/XTemplate/xtpl.php b/XTemplate/xtpl.php
@@ -156,22 +156,6 @@ function __construct ($file, $alt_include = "", $mainblock="main") {
 	//$this->scan_globals();
 }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    function XTemplate($file, $alt_include = "", $mainblock="main"){
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct($file, $alt_include, $mainblock);
-    }
-
-
-
 /***************************************************************************/
 /***[ public stuff ]********************************************************/
 /***************************************************************************/

diff --git a/data/SugarBean.php b/data/SugarBean.php
@@ -500,23 +500,6 @@ public function __construct()
         $this->populateDefaultValues();
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8,
-     * please update your code, use __construct instead
-     * @see SugarBean::__construct
-     */
-    public function SugarBean()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, ' .
-            'please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
-
     /**
      * Loads the definition of custom fields defined for the module.
      * Local file system cache is created as needed.

diff --git a/include/Dashlets/Dashlet.php b/include/Dashlets/Dashlet.php
@@ -104,21 +104,6 @@ public function __construct($id)
         $this->id = $id;
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function Dashlet($id)
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct($id);
-    }
-
-
     /**
      * Returns the HTML for the configure icon
      *

diff --git a/include/Dashlets/DashletGeneric.php b/include/Dashlets/DashletGeneric.php
@@ -153,20 +153,6 @@ public function __construct($id, $options = null)
         $this->lvs = new ListViewSmarty();
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function DashletGeneric($id, $options = null)
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct($id, $options);
-    }
-
     /**
      * Sets up the display options template
      *

diff --git a/include/DetailView/DetailView.php b/include/DetailView/DetailView.php
@@ -62,19 +62,7 @@ public function __construct()
         $this->local_app_strings =$app_strings;
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function DetailView()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
 
     public function processSugarBean($html_varName, $seed, $offset)

diff --git a/include/EditView/EditView.php b/include/EditView/EditView.php
@@ -75,21 +75,6 @@ public function __construct($module, $template)
         $this->ss = new Sugar_Smarty();
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function EditView($module, $template)
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct($module, $template);
-    }
-
-
     /**
      * Processes / setups the template
      * assigns all things to the template like mod_srings and app_strings

diff --git a/include/EditView/PopupQuickCreate.php b/include/EditView/PopupQuickCreate.php
@@ -55,21 +55,6 @@ public function __construct($module, $view='QuickCreate')
         $this->ev->defs['templateMeta']['form']['buttons'] = array('POPUPSAVE', 'POPUPCANCEL');
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function PopupQuickCreate($module, $view='QuickCreate')
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct($module, $view);
-    }
-
-
     public function process($module)
     {
         $form_name = 'form_QuickCreate_' . $module;

diff --git a/include/EditView/SubpanelQuickCreate.php b/include/EditView/SubpanelQuickCreate.php
@@ -158,20 +158,6 @@ public function __construct($module, $view='QuickCreate', $proccessOverride = fa
         }
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function SubpanelQuickCreate($module, $view='QuickCreate', $proccessOverride = false)
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct($module, $view, $proccessOverride);
-    }
-
     public function process($module)
     {
         if ($_REQUEST['target_action'] == 'QuickCreate') {

diff --git a/include/EditView/SubpanelQuickEdit.php b/include/EditView/SubpanelQuickEdit.php
@@ -148,20 +148,6 @@ public function __construct($module, $view='QuickEdit', $proccessOverride = fals
         }
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function SubpanelQuickEdit($module, $view='QuickEdit', $proccessOverride = false)
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct($module, $view, $proccessOverride);
-    }
-
     public function process($module)
     {
         $form_name = 'form_Subpanel'.$this->ev->view .'_'.$module;

diff --git a/include/ListView/ListViewData.php b/include/ListView/ListViewData.php
@@ -73,19 +73,7 @@ public function __construct()
         $this->db = DBManagerFactory::getInstance('listviews');
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function ListViewData()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
 
     /**

diff --git a/include/ListView/ListViewDisplay.php b/include/ListView/ListViewDisplay.php
@@ -84,19 +84,7 @@ public function __construct()
         $this->searchColumns = array() ;
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function ListViewDisplay()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
 
     public function shouldProcess($moduleDir)

diff --git a/include/ListView/ListViewFacade.php b/include/ListView/ListViewFacade.php
@@ -88,20 +88,6 @@ public function __construct($focus, $module, $type = 0)
          $this->build();
      }
 
-     /**
-      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-      */
-     public function ListViewFacade($focus, $module, $type = 0)
-     {
-         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-         if (isset($GLOBALS['log'])) {
-             $GLOBALS['log']->deprecated($deprecatedMessage);
-         } else {
-             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-         }
-         self::__construct($focus, $module, $type);
-     }
-
      /**
       * Retrieves display columns on list view of specified module
       *

diff --git a/include/ListView/ListViewXTPL.php b/include/ListView/ListViewXTPL.php
@@ -62,19 +62,7 @@ public function __construct()
         parent::__construct();
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function ListViewXTPL()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
 
     /**

diff --git a/include/Localization/Localization.php b/include/Localization/Localization.php
@@ -101,19 +101,7 @@ public function __construct()
         $this->loadCurrencies();
     }
 
-    /**
-     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-     */
-    public function Localization()
-    {
-        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if (isset($GLOBALS['log'])) {
-            $GLOBALS['log']->deprecated($deprecatedMessage);
-        } else {
-            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-        }
-        self::__construct();
-    }
+
 
     /**
      * returns an array of Sugar Config defaults that are determined by locale settings