Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - Registro horario - Error JS en página de Login #281

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

ManuSinergiaCRM
Copy link
Collaborator

Descripción

Se detecta que en la página de login del CRM se produce un error JS relacionado con el botón de registro horario.

SticTimeTrackerButtonInMainMenu.js?v=ZWwyFYVMVtOoy_EHWuepyA:36 Failed to get time tracker button status. Could not find out if there is a time record started for today and for the logged in employee: SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

Este PR resuelve la incidencia comprobando, antes de consultar si tiene que pintar o no dicho botón, que no se esté en la página de Login.

[FYI] Además, se detecta que algunos comentarios relacionados con el PR principal que implemento esta funcionalidad no tenían indicado el ID de dicho PR, por lo que he aprovechado este PR para indicarlo.

Pruebas

  1. Acceder a la página de login y comprobar que ya no se muestra el error JS
  2. Acceder al CRM y comprobar que el botón se muestra correctamente una vez logueado (tener en cuenta las condiciones para que se muestre el botón: Módulo activado y checkbox de Registro horario en el perfil del usuario activado)

Copy link

github-actions bot commented Jun 20, 2024

Actions executed at: 2024-07-23 15:14:24.

Copy link
Collaborator

@PaulaaSTIC PaulaaSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)probado

Copy link
Collaborator

@jordiSTIC jordiSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado

Copy link
Collaborator

@jordiSTIC jordiSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado

@enricsinergia enricsinergia merged commit aeeee0d into develop Jul 23, 2024
1 check passed
@enricsinergia enricsinergia deleted the bug/avoidJSErrorInLoginView branch July 23, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants