Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix - Inscripciones - Resetear campos calculados despues de duplicar masivamente inscripciones #296

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Hotfix - Inscripciones - Resetear campos calculados despues de duplicar masivamente inscripciones #296

merged 1 commit into from
Jul 23, 2024

Conversation

juanSTIC
Copy link
Collaborator

@juanSTIC juanSTIC commented Jul 5, 2024 •
edited
Loading

Descripción

Para resolver el issue se añade de forma directa el reseteo (a null) del valor de los campos attended_hours y attendance_percentage cuando se trata de un nuevo registro.

Pruebas

  • Duplicar masivamente inscripciones que tengan valor en los campos attended_hours y attendance_percentage , asociandoles en la misma operación a un evento que no tenga sesiones (y por tanto asistencias) asociadas.
  • Verificar que las inscripciones creadas tienen vacío los campos indicados.

@juanSTIC juanSTIC self-assigned this Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

Actions executed at: 2024-07-23 15:30:21.

@juanSTIC juanSTIC force-pushed the bug/resetClonedRegistrations branch from 7968b35 to a9c6aa2 Compare July 5, 2024 09:21
@juanSTIC juanSTIC added bug Something isn't working Eventos e inscripciones labels Jul 5, 2024
@juanSTIC juanSTIC requested a review from AlbertoSTIC July 5, 2024 09:31
@juanSTIC juanSTIC linked an issue Jul 5, 2024 that may be closed by this pull request
Incidencia - Inscripciones - No se recalcula horas ni porcentajes de asistencia tras duplicación masiva #295
Closed
@AlbertoSTIC AlbertoSTIC requested review from ainaraRT and PaulaaSTIC and removed request for AlbertoSTIC July 9, 2024 08:15
ainaraRT
ainaraRT approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@ainaraRT ainaraRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado

PaulaaSTIC
PaulaaSTIC approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@PaulaaSTIC PaulaaSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)probado

@enricsinergia enricsinergia merged commit ab69554 into develop Jul 23, 2024
1 check passed
@enricsinergia enricsinergia deleted the bug/resetClonedRegistrations branch July 23, 2024 15:30
@jalbaiges jalbaiges changed the title Hotfix - Incripciones - Resetear campos calculados despues de duplicar masivamente inscripciones Hotfix - Inscripciones - Resetear campos calculados despues de duplicar masivamente inscripciones Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulaaSTIC PaulaaSTIC PaulaaSTIC approved these changes

@ainaraRT ainaraRT ainaraRT approved these changes

Assignees

@juanSTIC juanSTIC

Labels
bug Something isn't working Eventos e inscripciones
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incidencia - Inscripciones - No se recalcula horas ni porcentajes de asistencia tras duplicación masiva
4 participants
@juanSTIC @ainaraRT @PaulaaSTIC @enricsinergia