Hotfix - Usuarios - Generación automática de contraseña con requisitos de seguridad #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actions executed at: 2024-11-19 15:30:33. |
AlbertoSTIC
requested review from
ManuSinergiaCRM and
ainaraRT
and removed request for
juanSTIC and
AlbertoSTIC
ManuSinergiaCRM
requested changes
Oct 28, 2024
modules/Users/User.php
Outdated
|
|
||
| // Get password requirements | ||
| $length = 6; | ||
| if (isset($res['minpwdlength']) && is_numeric($res['minpwdlength']) && $res['minpwdlength'] < $length) { |
There was a problem hiding this comment.
En caso de configurar un número mayor a 6 no entra en el IF
--> Cambiar $res['minpwdlength'] < $length por $res['minpwdlength'] > $length o $res['minpwdlength'] != $length dependiendo de si queremos que la contraseña tenga 6 caracteres de longitud mínima o no.
There was a problem hiding this comment.
Corregido: Asumido que la longitud mínima será 6: en la antigua generación de contraseñas siempre se generaban de longitud 6
modules/Users/User.php
Outdated
| $password .= implode('', $requirements); | ||
|
|
||
| // Create other random characters | ||
| for ($i = 0; $i < $length - count($requirements) + 1; $i++) { // loop and create password |
There was a problem hiding this comment.
Se crea una contraseña con un carácter más de lo indicado. Cambiar $i < $length ... por $i <= $length o no sumar el + 1
|
PR SA: salesagility#10592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripción
Si se definía en "Administración - Usuarios - Administración de contraseñas" una configuración de seguridad de contraseñas, y a la vez se habilitaba la generación de contraseñas por el sistema, las contraseñas generadas automáticamte no cumplían los requisitos de seguridad definidos.
Solución propuesta
Se ha modificado la función
User::generatePassword()para que genere una contraseña teniendo en cuenta el cumplimiento de los requisitos de seguridad definidos en$sugar_config['passwordsetting']Pruebas
En una instancia con servidor de correo saliente configurado: