Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement - General - Herramienta Rector: Gestión correcta de errores internos #503

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jordiSTIC
Copy link
Collaborator

@jordiSTIC jordiSTIC commented Dec 3, 2024

Descripción

En la ejecución de Rector en algunas instancias, se ha observado que se produce un error interno en su ejecución.

Este PR recoge los errores internos de Rector en su ejecución y los muestra en el fichero de salida

Pruebas

Al no localizar las reglas que al ejecutarse producen el error interno de Rector, la validación de este PR se propone realizarla analizando el código, teniendo en cuenta que en esta corrección:

  • Se muestran los errores provinientes de stderr (guardados en errorResults de la clase RectorCheckResultHelper)
  • Se tratan también los errores mostrados en el resultado después de la cadena [ERROR]

@jordiSTIC jordiSTIC self-assigned this Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Actions executed at: 2024-12-19 08:42:39.

@jordiSTIC jordiSTIC marked this pull request as ready for review December 17, 2024 16:33
Copy link
Collaborator

@AlbertoSTIC AlbertoSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobado

Copy link
Collaborator

@ManuSinergiaCRM ManuSinergiaCRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)probado

@AlbertoSTIC AlbertoSTIC merged commit 08846a9 into develop Dec 19, 2024
1 check passed
@AlbertoSTIC AlbertoSTIC deleted the improvement/rectorCorrections branch December 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants