Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOMINMAX for Windows compatibility #1247

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

tobiasdiez
Copy link
Contributor

Some Windows compiler still provide their own min/max functions which leads to conflicts such as

..\subprojects\factory\factory\include\factory/templates/ftmpl_array.h(32): warning C4003: not enough arguments for function-like macro invocation 'min'
..\subprojects\factory\factory\include\factory/templates/ftmpl_array.h(33): warning C4003: not enough arguments for function-like macro invocation 'max'
..\subprojects\factory\factory\include\factory/templates/ftmpl_array.h(32): error C2059: syntax error: ')'

To prevent these name conflicts a simple #define NOMINMAX is added.

@hannes14 hannes14 merged commit 0b770b1 into Singular:spielwiese Oct 29, 2024
72 of 106 checks passed
@tobiasdiez tobiasdiez deleted the no-min-max branch October 29, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants