Skip to content

Commit

Permalink
Fix react dependencies to improve test reliability (withastro#3673)
Browse files Browse the repository at this point in the history
* Fix local react tests by unifying versions

* Add missing dependencies to react tests

* Add changeset

* Fix lockfile

Co-authored-by: Matthew Phillips <[email protected]>
  • Loading branch information
hippotastic and matthewp authored Jun 22, 2022
1 parent 530deaf commit 8e5bd9e
Show file tree
Hide file tree
Showing 9 changed files with 26 additions and 10 deletions.
4 changes: 3 additions & 1 deletion test/fixtures/0-css/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
"@astrojs/react": "workspace:*",
"@astrojs/svelte": "workspace:*",
"@astrojs/vue": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 3 additions & 1 deletion test/fixtures/astro-attrs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
"private": true,
"dependencies": {
"@astrojs/react": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 3 additions & 1 deletion test/fixtures/astro-client-only/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"dependencies": {
"@astrojs/svelte": "workspace:*",
"@astrojs/react": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 3 additions & 1 deletion test/fixtures/astro-dynamic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"dependencies": {
"@astrojs/react": "workspace:*",
"@astrojs/svelte": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 3 additions & 1 deletion test/fixtures/astro-partial-html/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
"private": true,
"dependencies": {
"@astrojs/react": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 2 additions & 2 deletions test/fixtures/error-react-spectrum/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"@adobe/react-spectrum": "^3.18.0",
"@astrojs/react": "workspace:*",
"astro": "workspace:*",
"react": "^17.0.2",
"react-dom": "^17.0.2"
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 3 additions & 1 deletion test/fixtures/errors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
"@astrojs/solid-js": "workspace:*",
"@astrojs/svelte": "workspace:*",
"@astrojs/vue": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 3 additions & 1 deletion test/fixtures/slots-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
"private": true,
"dependencies": {
"@astrojs/react": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}
4 changes: 3 additions & 1 deletion test/fixtures/static-build-frameworks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"dependencies": {
"@astrojs/react": "workspace:*",
"@astrojs/preact": "workspace:*",
"astro": "workspace:*"
"astro": "workspace:*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
}
}

0 comments on commit 8e5bd9e

Please sign in to comment.